[GitHub] storm issue #2800: STORM-3162: Fix concurrent modification bug

2018-09-15 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2800 Please take a look at #2836 as an alternative. It is a much bigger patch, but I think the refactoring it does will make things much easier longer term. Having done the other patch I think this one

[GitHub] storm issue #2800: STORM-3162: Fix concurrent modification bug

2018-09-15 Thread zd-project
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2800 As far as my understanding of the code goes I believe this fix should resolve this particular issue. However my understanding in HB cache was limited and the PR was pushed hastily during my last

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-15 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2836 STORM-3162: Cleanup heartbeats cache and make it thread safe This is an alternative to #2800 @zd-project I had such trouble really understanding what was happening with the heartbeat

[GitHub] storm issue #2789: STORM-3173: flush metrics to ScheduledReporter on shutdow...

2018-09-15 Thread zd-project
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2789 #2764 also depends on resolution of this issue. Please consider merging that as well as part of the patch. ---

[GitHub] storm issue #2714: STORM-3101: Fix unexpected metrics registration in StormM...

2018-09-15 Thread zd-project
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2714 This should be closed after #2805 is resolved. ---

[GitHub] storm issue #2832: STORM-3205 Optimization in TuplImpl

2018-09-15 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2832 travis failure seems unrelated. ---

[GitHub] storm pull request #2833: STORM-3225: Use MediaType for check

2018-09-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2833#discussion_r217882011 --- Diff: storm-webapp/src/main/java/org/apache/storm/daemon/ui/filters/AuthorizedUserFilter.java --- @@ -79,7 +80,7 @@ public static Response

[GitHub] storm issue #2833: STORM-3225: Use MediaType for check

2018-09-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2833 +1 ---

[GitHub] storm pull request #2835: STORM-3222: Fix KafkaSpout internals to use Linked...

2018-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2835 ---

[GitHub] storm issue #2829: STORM-3222: Fix KafkaSpout internals to use LinkedList in...

2018-09-15 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2829 Sorry my bad, there is an overflow.

Is the powered-by file in the Storm repository necessary?

2018-09-15 Thread Stig Rohde Døssing
Hi, We have a powered-by.md file in the Storm repository's /docs directory. There's also a powered-by file in the storm-site repo root, as well as in each release directory. The storm-site root powered-by is the one linked to by the Storm site, and I don't believe it's being updated based on the

[GitHub] storm pull request #2834: STORM-3226: Update error message to be more clear

2018-09-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2834#discussion_r217882026 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -135,7 +135,7 @@ public Supervisor(Map conf, IContext

[GitHub] storm issue #2834: STORM-3226: Update error message to be more clear

2018-09-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2834 +1 ---