[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 Thanks @kosii Merged to master and 1.x-branch. You can close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @arunmahadevan yes, check #1811 please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii can you cherry pick the commits from 1606 plus your commits and raise a pr for 1.x branch? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @arunmahadevan actually my patch depends on #2020, which isn't yet in 1.x-branch. how should we proceed? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 Yes, I'll look into that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii thanks for the PR. Merged it to master. Can you also raise a PR for 1.x-branch ? I am getting some merge conflicts while trying to cherry-pick. --- If your project is set up

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii thanks for working on this. Will take a look one final time and merge it if it looks fine. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @arunmahadevan I'm very sorry for disappearing for such a long time. I addressed all the comments, I also fixed the race condition in my last commit --- If your project is set up for it, you can

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii can you up-merge and push your local repo changes so that we can merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @HeartSaVioR I addressed most of the comments in my local repo, but not pushed yet. If I have some time this week (probably Friday) I'll clean it up, and commit. Sorry for the delay --- If your

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1470 @kosii Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii I have gone through the latest changes and left a few comments. The idea of using tombstone looks nice and once the comments are addressed its good to merge. --- If your project is

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 A short list of modifications - I went for the `Optional` class. Using your idea largely simplified the code. - delete now returns the current value - I didn't use a different set to

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 Thanks @arunmahadevan for the thorough review, I'm gonna address each comments asap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii the delete api is useful. Lets also try to see if we could handle the deletes by maintaining an entry within the pendingPrepare itself and avoid the extra hashsets and synchronized as