[GitHub] storm issue #1605: STORM-2014: Put logic around dropping messages into Retry...

2017-02-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1605
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1605: STORM-2014: Put logic around dropping messages into Retry...

2017-02-02 Thread harshach
Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1605
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1605: STORM-2014: Put logic around dropping messages into Retry...

2016-09-22 Thread srdo
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/1605
  
Squashed. I hope this commit message is clearer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1605: STORM-2014: Put logic around dropping messages into Retry...

2016-09-22 Thread hmcl
Github user hmcl commented on the issue:

https://github.com/apache/storm/pull/1605
  
I am +1 overall. Please format the commit message to be easy to read and 
squash the two commits. This is a simple change that should have only one 
commit. We can merge after that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1605: STORM-2014: Put logic around dropping messages into Retry...

2016-09-16 Thread srdo
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/1605
  
@hmcl ping. Any input on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1605: STORM-2014: Put logic around dropping messages into Retry...

2016-08-02 Thread priyank5485
Github user priyank5485 commented on the issue:

https://github.com/apache/storm/pull/1605
  
+1 (non-binding). I had talked to @hmcl briefly about this. We should have 
his review as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---