[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user ppoulosk commented on the issue: https://github.com/apache/storm/pull/1661 Yes. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1661 @ppoulosk Could we close this as Supervisor V2 was merged? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user ppoulosk commented on the issue: https://github.com/apache/storm/pull/1661 @HeartSaVioR @revans2 I have no preference which solution gets pulled in first. I fixed the comment, retested, squashed the three commits into one and pushed it to my branch.

[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1661 @ppoulosk Do you have any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1661 I would be happy to pull that fix back into a separate patch. @ppoulosk this patch looks fine to me, my only concern would be documenting it a little more explaining that the state change might not

[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1661 From JIRA comment @revans2 said he fixed this issue from Supervisor V2 patch. @revans2 Since we saw builds failing (high chance from my dev.) how about addressing build issue before

[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user abellina commented on the issue: https://github.com/apache/storm/pull/1661 +1 thanks @ppoulosk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user ppoulosk commented on the issue: https://github.com/apache/storm/pull/1661 Coded fix, retested, and pushed. Thanks!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1661: [STORM-2071] Add in retry after rebalance in unit test

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1661 +1 once comments from @abellina are addressed. Nice finding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does