[GitHub] storm issue #1676: STORM-2085: Remove guava from storm-core pom.
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1676 No wait, dependency:analyze indicates that guava is used? Not sure how it compiled though. Investigating. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1676: STORM-2085: Remove guava from storm-core pom.
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1676 Nope I was wrong it compiles just fine and there is no guava except being pulled in by curator test. Yes +1 for this, and +1 for pulling it into 1.x if possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1676: STORM-2085: Remove guava from storm-core pom.
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1676 I'm +1 on this, but I am a little nervous I may have started using guava as part of the supervisor V2. Let me try and run some tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1676: STORM-2085: Remove guava from storm-core pom.
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1676 I'm +1 on this. @revans2 @ptgoetz Could you review this as well? This is a change of dependency but removing shaded dependency. Which version line do you think we can apply? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1676: STORM-2085: Remove guava from storm-core pom.
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1676 We shaded Guava which downstream shouldn't rely on, so I think we can apply this to 1.x if applicable. (I'm not sure we also want to apply this to 1.0.x.) ps. Since external modules use Guava so we still maintain the main version of Guava. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1676: STORM-2085: Remove guava from storm-core pom.
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1676 Do we want this on any of the 1.* branches? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
