[GitHub] storm issue #1677: STORM-1985: Admin Commands
Github user kamleshbhatt commented on the issue: https://github.com/apache/storm/pull/1677 @revans2 Thanks for reviewing the changes. Resolved the merge conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1677: STORM-1985: Admin Commands
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1677 +1 please upmerge though. There is a very minor merge conflict. Then ping me and I'll merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1677: STORM-1985: Admin Commands
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1677 @kamleshbhatt sorry I lost track of this, looking again now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1677: STORM-1985: Admin Commands
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1677 Looks good to me. I have a few tests that I want to run, but in general it looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1677: STORM-1985: Admin Commands
Github user kamleshbhatt commented on the issue: https://github.com/apache/storm/pull/1677 Applied the review comments. Please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1677: STORM-1985: Admin Commands
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1677 I am done going through the code. Beyond this we need to update storm.py to add in this command, and documentation on how to use it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1677: STORM-1985: Admin Commands
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1677 For reference the original code that this is replacing was ``` (defn cleanup-corrupt-topologies! [nimbus] (let [storm-cluster-state (:storm-cluster-state nimbus) blob-store (:blob-store nimbus) code-ids (set (code-ids blob-store)) active-topologies (set (.active-storms storm-cluster-state)) corrupt-topologies (set/difference active-topologies code-ids)] (doseq [corrupt corrupt-topologies] (log-message "Corrupt topology " corrupt " has state on zookeeper but doesn't have a local dir on Nimbus. Cleaning up...") (.remove-storm! storm-cluster-state corrupt) (if (instance? LocalFsBlobStore blob-store) (doseq [blob-key (get-key-list-from-id (:conf nimbus) corrupt)] (.remove-blobstore-key! storm-cluster-state blob-key)) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
