[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1742 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1742 Also updated the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1742 OK. nice :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1742 @vesense Yes I plan to update #1777 after merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1742 @HeartSaVioR It would be better to add some `how to use` document. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1742 @vesense Thanks for reviewing, I addressed all of your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1742 Thanks @HeartSaVioR LGTM +1 Just left several comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
