[GitHub] storm issue #1768: STORM-2194: Report error and die, not report error or die

2016-12-01 Thread chawco
Github user chawco commented on the issue: https://github.com/apache/storm/pull/1768 I've left some follow up comments in [1767](https://github.com/apache/storm/pull/1767). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #1768: STORM-2194: Report error and die, not report error or die

2016-11-21 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1768 -1. InterruptedException we often use to indicate that the process is shutting down, and we want to not blow up when we see them. Perhaps what we want to do is to better document it. ---