[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 Thanks @arunmahadevan. :) Out of curiosity, why don't we use github's merge branch feature to merge branches directly from this page? Or was it just a temporary thing because of integration tests

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1798 @aandis thanks for the work, merged to master and 1.x-branch. You can close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1798 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 @HeartSaVioR @arunmahadevan ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 @HeartSaVioR yep. will do in next couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1798 @aandis Could you address review comments from @arunmahadevan? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 Ping @HeartSaVioR @arunmahadevan can you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1798: Storm 2203 Add a getAll method to KeyValueState interface

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1798 @aandis Looks great. Could you add tests if possible? You may want to rename the prefix of the title to `STORM-2203` so that it can be linked to JIRA issue automatically. Thanks in