Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1800
+1 from me. All manual tests are OK: build, dist packaging, unpacking,
running drpc service.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1800
Okay, that last commit answered a lot of questions I had regarding
packaging. ;)
+1 I was able to build a distribution, unpack it, and run the drpc service.
---
If your project is set up fo
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1800
@revans2 Okay. Let me review the packaging changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1800
@ptgoetz I have updated the packaging to have a separate directory for the
DRPC server dependencies. I have run manual tests and everything works. The
big difference is that {{apache-storm-2.0.0-SN
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1800
One more option, still ugly, but with a lot less impact. I can do
something similar to Hadoop. They use several different invocations of the
maven assembly plugin into directories (predates moduleS
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1800
So shading is not really an option for jersey.
I was able to split the DRPC server off into its own package with tests,
but packaging it up with the assembly plugin is proving to be difficult. If
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1800
Shading Jersey is becoming rather difficult (lots of dependencies including
aop and dependency injection. Splitting the DPRC server off into it's own
location seems much simpler and less error prone
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1800
@ptgoetz if this looks good as is I will look into shading Jersey.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1800
Rebased again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1800
+1. Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1800
Rebased the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1800
Will rebase soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
12 matches
Mail list logo
