[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1810 Master branch of storm-hbase still has guava as dependency even we use Caffeine, since hbase-server depends on Guava 16.0.1. So this patch doesn't add new guava dependency. I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1810 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1810 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1810 @ambud The last change looks good. Please squash the commits into one. I'll merge after rebasing. If you mind squashing I'd be happy to do it instead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Github user ambud commented on the issue: https://github.com/apache/storm/pull/1810 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Github user ambud commented on the issue: https://github.com/apache/storm/pull/1810 @HeartSaVioR i fixed the issues; build failed because what seems to be a transient failure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1810 @ambud Code looks good, but indentation is really off. Could you take care of it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Github user ambud commented on the issue: https://github.com/apache/storm/pull/1810 https://github.com/apache/storm/pull/1783 original PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
