Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2363
@revans2 Thanks. I opened https://issues.apache.org/jira/browse/STORM-2809.
When I have some time I'll probably look at this too, to see if I can figure
out what's going on.
Regarding the 3
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2363
@srdo
3 mins would correspond to a timeout that we have when the supervisor gets
confused.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2363
@revans2 I think something in this PR is causing topology deployment to
either fail or be really slow occasionally.
The integration test has been failing fairly consistently since
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2363
OK. Thanks for quick addressing. +1 again.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2363
@HeartSaVioR I addressed your review comments. I didn't change the name of
shouldLogLeader, but I added javadocs to make it clear what it does.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2363
@kishorvpatil I addressed your review comments.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2363
#2345 was merged so I rebased to make it more clear the new changes. I
actually delete code now :).
---
