Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2669
Actually we just hit this in production so thanks again @pczb for finding
and fixing this.
---
Github user pczb commented on the issue:
https://github.com/apache/storm/pull/2669
@srdo @revans2 thanks for your review, i just squash all commit in one
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2669
Once you make the corresponding changes on #2661 I would be happy to merge
them both in.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2669
LGTM, thanks for addressing comments
---
Github user pczb commented on the issue:
https://github.com/apache/storm/pull/2669
@srdo add doc specification, i was wonder if we need remove synchronized
when bind port
@revans2 just as srdo says the connection will be closed by the worker
before worker shutdown.
i will
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2669
As far as I can tell all connections are still being shut down with this
change. The connections cached by WorkerState are closed during worker shutdown
in
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2669
The original code added this so when shutting down the context we could be
sure that all ongoing connections were also terminated as cleanly as possible.
After this change that is only true for the
Github user pczb commented on the issue:
https://github.com/apache/storm/pull/2669
@revans2 could you help review this, i see your pull request #2436 is
related to connection cache . and the travis fail is not related to this pr.
---
