[GitHub] storm pull request #1697: STORM-2018: Supervisor V2

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1697


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1697: STORM-2018: Supervisor V2

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1697#discussion_r81442669
  
--- Diff: storm-core/src/jvm/org/apache/storm/command/HealthCheck.java ---
@@ -0,0 +1,126 @@
+/**
--- End diff --

This file seems to be clashed with healthcheck.clj.

```
2016-10-01 11:53:24.105 timer o.a.s.d.s.DefaultUncaughtExceptionHandler 
[ERROR] Error when processing event
java.lang.NoClassDefFoundError: org/apache/storm/command/HealthCheck (wrong 
name: org/apache/storm/command/healthcheck)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at 
org.apache.storm.daemon.supervisor.timer.SupervisorHealthCheck.run(SupervisorHealthCheck.java:36)
at org.apache.storm.StormTimer$1.run(StormTimer.java:190)
at org.apache.storm.StormTimer$StormTimerTask.run(StormTimer.java:83)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1697: STORM-2018: Supervisor V2

[revans2]

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1697#discussion_r79723534
  
--- Diff: pom.xml ---
@@ -1067,8 +1067,8 @@
 org.apache.maven.plugins
 maven-compiler-plugin
 
-1.7
-1.7
+1.8
+1.8
--- End diff --

Oops forgot to revert this, will go back to 1.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1697: STORM-2018: Supervisor V2

[revans2]

GitHub user revans2 opened a pull request:

https://github.com/apache/storm/pull/1697

STORM-2018: Supervisor V2

Still need to do some more manual testing but the unit tests passed for me.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revans2/incubator-storm STORM-2018-1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1697.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1697


commit 318ab5f300e0820ab862cbeca04b7cb67699b938
Author: Robert (Bobby) Evans 
Date:   2016-09-20T19:59:07Z

STORM-2018: Supervisor V2




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---