[GitHub] storm pull request #1974: STORM-2038: Disable symlinks with a config option

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1974


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1974: STORM-2038: Disable symlinks with a config option

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1974#discussion_r104552433
  
--- Diff: 
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -341,6 +344,9 @@ public String slurpString(File location) throws 
IOException {
  * @throws IOException on any error.
  */
 public void createSymlink(File link, File target) throws IOException {
+if (_symlinksDisabled) {
+throw new IOException("Symlinks have been disabled, this 
hsould not be called");
--- End diff --

hsould -> should


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] storm pull request #1974: STORM-2038: Disable symlinks with a config option

[Jungtaek Lim]

Unsubscribe dev@ mailing list would help. More details are here:
http://storm.apache.org/getting-help.html

2017년 2월 28일 (화) 오전 10:33, linuxbyni...@gmail.com 님이
작성:

> Need some help here...  have disabled my feeds in github and am still
> receiving notifications.  What do I need to do to stop incoming emails
> for this project?
>
> On 02/27/2017 03:09 PM, revans2 wrote:
> > GitHub user revans2 opened a pull request:
> >
> >  https://github.com/apache/storm/pull/1974
> >
> >  STORM-2038: Disable symlinks with a config option
> >
> >  This is built on top of #1972 but I have not ported it to other
> branches yet, so I would like to keep the two separate.  Once reviews are
> done on this version I will port it to 1.x and 1.0.x (as it apparently is a
> real pain for windows users)
> >
> > You can merge this pull request into a Git repository by running:
> >
> >  $ git pull https://github.com/revans2/incubator-storm
> STORM-2038-sym-link-alternative
> >
> > Alternatively you can review and apply these changes as the patch at:
> >
> >  https://github.com/apache/storm/pull/1974.patch
> >
> > To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >
> >  This closes #1974
> >
> > 
> > commit ca58d5437105cbd79504f06ce4aa65755d05d32b
> > Author: Robert (Bobby) Evans 
> > Date:   2017-02-27T18:11:29Z
> >
> >  STORM-2038:  No symlinks for local cluster
> >
> > commit 3a0758b61b3e4cf806c92fd6b2663fff008c4f7b
> > Author: Robert (Bobby) Evans 
> > Date:   2017-02-27T21:06:43Z
> >
> >  STORM-2038: Disable symlinks with a config option
> >
> > 
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastruct...@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
>

Re: [GitHub] storm pull request #1974: STORM-2038: Disable symlinks with a config option

[linuxbyni...@gmail.com]

Need some help here...  have disabled my feeds in github and am still 
receiving notifications.  What do I need to do to stop incoming emails 
for this project?


On 02/27/2017 03:09 PM, revans2 wrote:

GitHub user revans2 opened a pull request:

 https://github.com/apache/storm/pull/1974

 STORM-2038: Disable symlinks with a config option

 This is built on top of #1972 but I have not ported it to other branches 
yet, so I would like to keep the two separate.  Once reviews are done on this 
version I will port it to 1.x and 1.0.x (as it apparently is a real pain for 
windows users)

You can merge this pull request into a Git repository by running:

 $ git pull https://github.com/revans2/incubator-storm 
STORM-2038-sym-link-alternative

Alternatively you can review and apply these changes as the patch at:

 https://github.com/apache/storm/pull/1974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

 This closes #1974
 


commit ca58d5437105cbd79504f06ce4aa65755d05d32b
Author: Robert (Bobby) Evans 
Date:   2017-02-27T18:11:29Z

 STORM-2038:  No symlinks for local cluster

commit 3a0758b61b3e4cf806c92fd6b2663fff008c4f7b
Author: Robert (Bobby) Evans 
Date:   2017-02-27T21:06:43Z

 STORM-2038: Disable symlinks with a config option




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1974: STORM-2038: Disable symlinks with a config option

[revans2]

GitHub user revans2 opened a pull request:

https://github.com/apache/storm/pull/1974

STORM-2038: Disable symlinks with a config option

This is built on top of #1972 but I have not ported it to other branches 
yet, so I would like to keep the two separate.  Once reviews are done on this 
version I will port it to 1.x and 1.0.x (as it apparently is a real pain for 
windows users) 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revans2/incubator-storm 
STORM-2038-sym-link-alternative

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1974


commit ca58d5437105cbd79504f06ce4aa65755d05d32b
Author: Robert (Bobby) Evans 
Date:   2017-02-27T18:11:29Z

STORM-2038:  No symlinks for local cluster

commit 3a0758b61b3e4cf806c92fd6b2663fff008c4f7b
Author: Robert (Bobby) Evans 
Date:   2017-02-27T21:06:43Z

STORM-2038: Disable symlinks with a config option




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---