Github user danny0405 closed the pull request at:
https://github.com/apache/storm/pull/2319
---
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138791919
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138781163
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138781061
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -244,15 +255,19 @@
;; Watches should be used for optimization. When ZK is
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138780949
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -123,6 +133,7 @@
(def SUPERVISORS-SUBTREE (str "/" SUPERVISORS-ROOT))
(def
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138780747
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -244,15 +255,19 @@
;; Watches should be used for optimization. When ZK is
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138659723
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -244,15 +255,19 @@
;; Watches should be used for optimization. When ZK is
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138663085
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138659373
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -244,15 +255,19 @@
;; Watches should be used for optimization. When ZK is
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138662304
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138657756
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -123,6 +133,7 @@
(def SUPERVISORS-SUBTREE (str "/" SUPERVISORS-ROOT))
(def
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138662036
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138103588
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -961,14 +1015,25 @@
;; tasks figure out what tasks to talk to by looking at
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138099459
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -961,14 +1015,25 @@
;; tasks figure out what tasks to talk to by looking at
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138097813
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -961,14 +1015,25 @@
;; tasks figure out what tasks to talk to by looking at
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138093197
--- Diff: storm-core/pom.xml ---
@@ -331,6 +331,10 @@
commons-codec
+org.rocksdb
+
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138092651
--- Diff: storm-core/pom.xml ---
@@ -331,6 +331,10 @@
commons-codec
+org.rocksdb
+
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138091372
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -758,6 +752,35 @@
(catch Exception e
(log-error e "Error
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138090333
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -62,26 +63,17 @@
(defn- assignments-snapshot [storm-cluster-state
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138074478
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -758,6 +752,35 @@
(catch Exception e
(log-error e "Error
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138073996
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -590,6 +583,7 @@
(set (keys
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138074935
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -351,6 +373,8 @@
(.sendLoadMetrics (:receiver worker) local-pop)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138080750
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -961,14 +1015,25 @@
;; tasks figure out what tasks to talk to by looking at
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138073574
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -62,26 +63,17 @@
(defn- assignments-snapshot [storm-cluster-state
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138074783
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -47,9 +48,30 @@
(defmulti mk-suicide-fn cluster-mode)
+(defn
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138074168
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -758,6 +752,35 @@
(catch Exception e
(log-error e "Error
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138071918
--- Diff: storm-core/pom.xml ---
@@ -331,6 +331,10 @@
commons-codec
+org.rocksdb
+
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/2319
[STORM-2693] Nimbus assignments promotion
Storm now doesn't support large cluster[ for example thousand of
supervisors] very well, for our production, topology submission/killing is very
28 matches
Mail list logo
