[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2537 ---

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852894 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -143,28 +146,28 @@ public String toString() {

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852904 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +459,33 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852132 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -519,6 +519,15 @@ private boolean isEmitTuple(List

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852072 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +459,33 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165851895 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -143,28 +146,28 @@ public String toString() {

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852060 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +459,33 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165850084 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -210,23 +215,26 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165850081 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -519,6 +519,15 @@ private boolean isEmitTuple(List

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165850087 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +451,33 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830316 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java --- @@ -196,13 +206,37 @@ public void

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165829893 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -210,23 +215,26 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830237 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +451,33 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830142 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -519,6 +519,15 @@ private boolean isEmitTuple(List

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830128 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -307,8 +307,12 @@ public void nextTuple() {

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830302 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java --- @@ -153,8 +163,8 @@ public void

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830301 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java --- @@ -153,8 +163,8 @@ public void

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830313 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java --- @@ -196,13 +206,37 @@ public void

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830248 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +451,33 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830275 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +451,33 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830219 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -519,6 +519,15 @@ private boolean isEmitTuple(List

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830294 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java --- @@ -109,7 +119,7 @@ public void

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830061 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -133,8 +133,8 @@ public void open(Map

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830031 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -89,7 +89,7 @@ private transient

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830279 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java --- @@ -85,4 +90,12 @@ public void

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830085 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -307,8 +307,12 @@ public void nextTuple() {

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165830283 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java --- @@ -85,4 +90,12 @@ public void

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2537 STORM-2914: Implement ProcessingGuarantee.NONE in the spout instead o… …f using enable.auto.commit https://issues.apache.org/jira/browse/STORM-2914 This change makes the spout