[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

2018-02-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2551


---

[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

2018-02-09 Thread HeartSaVioR 
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2551#discussion_r167374065
  
--- Diff: 
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -85,6 +85,7 @@ public void prepare(WorkerTopologyContext context, 
GlobalStreamId stream, List

[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

2018-02-09 Thread Ethanlm 
Github user Ethanlm commented on a diff in the pull request:

https://github.com/apache/storm/pull/2551#discussion_r167247297
  
--- Diff: 
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -85,6 +85,7 @@ public void prepare(WorkerTopologyContext context, 
GlobalStreamId stream, List

[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

2018-02-08 Thread HeartSaVioR 
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2551#discussion_r167094514
  
--- Diff: 
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -85,6 +85,7 @@ public void prepare(WorkerTopologyContext context, 
GlobalStreamId stream, List

[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

2018-02-07 Thread HeartSaVioR 
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2551#discussion_r166758132
  
--- Diff: 
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -85,6 +85,7 @@ public void prepare(WorkerTopologyContext context, 
GlobalStreamId stream, List

[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

2018-02-07 Thread Ethanlm 
Github user Ethanlm commented on a diff in the pull request:

https://github.com/apache/storm/pull/2551#discussion_r166755231
  
--- Diff: 
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -85,6 +85,7 @@ public void prepare(WorkerTopologyContext context, 
GlobalStreamId stream, List

[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

2018-02-07 Thread HeartSaVioR 
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2551#discussion_r166749574
  
--- Diff: 
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -44,7 +44,7 @@
 import org.slf4j.LoggerFactory;
 
 public class LoadAwareShuffleGrouping implements 
LoadAwareCustomStreamGrouping, Serializable {
-static final int CAPACITY = 1000;
+private int CAPACITY;
--- End diff --

If we no longer use it as constant, the name should be changed to lower 
case.


---

[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

2018-02-07 Thread HeartSaVioR 
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2551#discussion_r166750716
  
--- Diff: 
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -85,6 +85,7 @@ public void prepare(WorkerTopologyContext context, 
GlobalStreamId stream, List