[GitHub] storm pull request #2560: STORM-2896: Add tool to help users migrate offsets...

2018-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2560 ---

[GitHub] storm pull request #2560: STORM-2896: Add tool to help users migrate offsets...

2018-02-24 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2560#discussion_r170419602 --- Diff: docs/storm-kafka.md --- @@ -4,6 +4,10 @@ layout: documentation documentation: true --- +## Deprecated --- End diff --

[GitHub] storm pull request #2560: STORM-2896: Add tool to help users migrate offsets...

2018-02-19 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2560#discussion_r169182620 --- Diff: external/storm-kafka-migration/src/main/java/org/apache/storm/kafka/migration/KafkaTridentSpoutMigration.java --- @@ -69,24 +70,40 @@ public

[GitHub] storm pull request #2560: STORM-2896: Add tool to help users migrate offsets...

2018-02-19 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2560#discussion_r169182743 --- Diff: external/storm-kafka-migration/src/main/java/org/apache/storm/kafka/migration/KafkaSpoutMigration.java --- @@ -54,25 +55,30 @@

[GitHub] storm pull request #2560: STORM-2896: Add tool to help users migrate offsets...

2018-02-17 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2560 STORM-2896: Add tool to help users migrate offsets from storm-kafka t… …o storm-kafka-client I'm not sure if we want this in master as well? I'd like to make a similar tool for