[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173633130 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/EventHubConfig.java --- @@ -0,0 +1,342 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635092 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/PartitionReceiverFactory.java --- @@ -0,0 +1,57 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635613 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/format/DefaultEventDataFormat.java --- @@ -24,24 +24,24 @@ * into a

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635422 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/PartitionManager.java --- @@ -0,0 +1,132 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635150 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/Partitions.java --- @@ -25,17 +25,18 @@ * Represents all EventHub

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173634390 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/IEventHubReceiver.java --- @@ -0,0 +1,78 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635720 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/format/EventHubMessageDataScheme.java --- @@ -0,0 +1,54 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173634426 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/IEventHubReceiver.java --- @@ -0,0 +1,78 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173632056 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBoltConfig.java --- @@ -17,95 +17,185 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635542 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/PartitionManager.java --- @@ -0,0 +1,132 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173636763 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/state/ZookeeperStateStore.java --- @@ -0,0 +1,111 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173636774 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/state/ZookeeperStateStore.java --- @@ -0,0 +1,111 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173636662 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/state/ZookeeperStateStore.java --- @@ -0,0 +1,111 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173634917 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/OffsetFilter.java --- @@ -1,31 +1,40 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173636465 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpout.java --- @@ -17,246 +17,281 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173634451 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/IEventHubReceiver.java --- @@ -0,0 +1,78 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173636199 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpout.java --- @@ -17,246 +17,281 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635745 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/format/EventHubMessageDataScheme.java --- @@ -0,0 +1,54 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173634219 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/EventHubReceiverImpl.java --- @@ -0,0 +1,155 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635798 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/format/StringEventDataScheme.java --- @@ -15,60 +15,43 @@ * See the License

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173634302 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/EventHubReceiverImpl.java --- @@ -0,0 +1,155 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173632083 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBoltConfig.java --- @@ -17,95 +17,185 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173634265 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/EventHubReceiverImpl.java --- @@ -0,0 +1,155 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173636141 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpout.java --- @@ -17,246 +17,281 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173636628 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpoutConfig.java --- @@ -17,240 +17,99 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173634151 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/EventHubReceiverImpl.java --- @@ -0,0 +1,155 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173633145 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/EventHubConfig.java --- @@ -0,0 +1,342 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635700 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/format/IEventDataScheme.java --- @@ -15,30 +15,32 @@ * See the License for

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635852 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpout.java --- @@ -17,246 +17,281 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635004 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/PartitionManager.java --- @@ -0,0 +1,132 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173636020 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpout.java --- @@ -17,246 +17,281 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173635910 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpout.java --- @@ -17,246 +17,281 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631657 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -31,116 +30,131 @@ import org.slf4j.Logger;

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631364 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -31,116 +30,131 @@ import org.slf4j.Logger;

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173633306 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/EventHubMessage.java --- @@ -0,0 +1,151 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631476 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -31,116 +30,131 @@ import org.slf4j.Logger;

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631711 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -31,116 +30,131 @@ import org.slf4j.Logger;

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631928 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBoltConfig.java --- @@ -17,95 +17,185 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631823 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBoltConfig.java --- @@ -17,95 +17,185 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173633175 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/EventHubConfig.java --- @@ -0,0 +1,342 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631895 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBoltConfig.java --- @@ -17,95 +17,185 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631909 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBoltConfig.java --- @@ -17,95 +17,185 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631260 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -31,116 +30,131 @@ import org.slf4j.Logger;

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2588#discussion_r173631986 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBoltConfig.java --- @@ -17,95 +17,185 @@

[GitHub] storm pull request #2588: Microsoft Azure EventHubs Storm Spout and Bolt imp...

2018-03-06 Thread SreeramGarlapati
GitHub user SreeramGarlapati opened a pull request: https://github.com/apache/storm/pull/2588 Microsoft Azure EventHubs Storm Spout and Bolt improvements This is continuation of work done by @raviperi - update to the latest version of eventhubs java client -Introduce