Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2754
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209315575
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2052,12 @@ private int fragmentedCpu() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209311727
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,21 +2882,27 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209311534
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2052,12 @@ private int fragmentedCpu() {
Cluster
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209305519
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209304694
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209303917
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209301707
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209301358
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209299849
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209298650
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209298109
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209297840
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209296760
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209296628
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209154065
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153726
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153602
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153420
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153135
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter mkFileFilterForLogCleanup(long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209152841
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209152808
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209099125
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098407
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098259
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -62,6 +64,14 @@
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098067
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/ExceptionMeters.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097770
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,10 @@
public
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097464
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097286
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -251,10 +257,18 @@
private static final Meter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097038
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209096605
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209096098
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209095662
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209095253
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209094640
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209092525
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209092338
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209088518
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209087810
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209083886
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209082396
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209072290
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209046204
--- Diff:
storm-server/src/test/java/org/apache/storm/metric/StormMetricsRegistryTest.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078867
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,10 @@
public class
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078282
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -251,10 +257,18 @@
private static final Meter
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078742
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209069385
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209079357
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/ExceptionMeters.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209077587
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209047681
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209079798
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -62,6 +64,14 @@
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209077210
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209065332
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,11 @@
public class
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209074521
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209076140
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209075962
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File dir)
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209075463
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter mkFileFilterForLogCleanup(long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209071814
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209048376
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -193,24 +198,23 @@ public Response
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209070836
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2891,33 +2884,26 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209068547
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2891,33 +2884,26 @@ public void launchServer() throws Exception {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209066631
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -267,8 +267,8 @@
private static final Histogram
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209067011
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2891,33 +2884,26 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209039163
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2890,22 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209037387
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
---
@@ -186,7 +192,22 @@ private boolean
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209037023
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2057,13 @@ private int fragmentedCpu() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209036572
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209031413
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2890,22 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209030437
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209023115
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209022892
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209005776
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209004673
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208723928
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2219,21 +2288,16 @@ private void mkAssignments(String scratchTopoId)
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208707067
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -134,6 +150,7 @@ public Response
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208723798
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2057,13 @@ private int fragmentedCpu() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208691016
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208726809
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208705884
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -55,6 +63,8 @@ public Response
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208704852
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208706459
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/WorkerLogs.java
---
@@ -88,9 +87,14 @@ public void setLogFilePermission(String
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208703040
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
---
@@ -186,7 +192,22 @@ private boolean
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208719630
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +748,99 @@ private static int
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208689498
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,11 @@
public
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208691270
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208718349
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +748,99 @@ private static int
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208703547
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -95,6 +102,9 @@ public LogCleaner(Map stormConf,
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208651482
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -265,32 +269,26 @@ public Response
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208377660
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -48,6 +53,30 @@ public static Meter registerMeter(String name)
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208394271
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -193,24 +198,23 @@ public Response
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208702901
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
---
@@ -124,6 +128,7 @@ public int
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208710506
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2890,22 @@ public void launchServer() throws Exception {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208377360
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/ReportWorkerHeartbeats.java
---
@@ -51,6 +51,7 @@ public void run() {
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2754
STORM-3133: Extend metrics on Nimbus and LogViewer
This PR is based on both #2743 and #2753 (merged) and implements the
following metrics:
LogViewer:
- [x] Time to complete one
94 matches
Mail list logo
