[GitHub] storm pull request #2834: STORM-3226: Update error message to be more clear

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2834


---

[GitHub] storm pull request #2834: STORM-3226: Update error message to be more clear

[revans2]

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/storm/pull/2834#discussion_r218116277
  
--- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java 
---
@@ -135,7 +135,7 @@ public Supervisor(Map conf, IContext 
sharedContext, ISupervisor
 (String) conf.get(DaemonConfig.SUPERVISOR_AUTHORIZER), conf);
 if (authorizationHandler == null && 
conf.get(DaemonConfig.NIMBUS_AUTHORIZER) != null) {
 throw new IllegalStateException("It looks like authorization 
is turned on for nimbus but not for the "
-+ "supervisor");
++ "supervisor ( " + DaemonConfig.SUPERVISOR_AUTHORIZER 
+ " is not set)");
--- End diff --

Will do on checkin.


---

[GitHub] storm pull request #2834: STORM-3226: Update error message to be more clear

[srdo]

Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/2834#discussion_r217882026
  
--- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java 
---
@@ -135,7 +135,7 @@ public Supervisor(Map conf, IContext 
sharedContext, ISupervisor
 (String) conf.get(DaemonConfig.SUPERVISOR_AUTHORIZER), conf);
 if (authorizationHandler == null && 
conf.get(DaemonConfig.NIMBUS_AUTHORIZER) != null) {
 throw new IllegalStateException("It looks like authorization 
is turned on for nimbus but not for the "
-+ "supervisor");
++ "supervisor ( " + DaemonConfig.SUPERVISOR_AUTHORIZER 
+ " is not set)");
--- End diff --

Nit: The `` part seems a little awkward. Maybe replace with a single 
period.


---

[GitHub] storm pull request #2834: STORM-3226: Update error message to be more clear

[revans2]

GitHub user revans2 opened a pull request:

https://github.com/apache/storm/pull/2834

STORM-3226: Update error message to be more clear



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revans2/incubator-storm STORM-3226

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2834


commit fdab9f5163ad5b56049fe4d51c7a0542048c3873
Author: Robert (Bobby) Evans 
Date:   2018-09-14T17:32:19Z

STORM-3226: Update error message to be more clear




---