[GitHub] struts pull request #132: WW-4780 : upgraded version of log4j2 to 2.8.2

2017-04-20 Thread sdutry
GitHub user sdutry opened a pull request: https://github.com/apache/struts/pull/132 WW-4780 : upgraded version of log4j2 to 2.8.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sdutry/struts WW-4780 Alternatively you can

[GitHub] struts pull request #132: WW-4780 : upgraded version of log4j2 to 2.8.2

2017-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] struts issue #132: WW-4780 : upgraded version of log4j2 to 2.8.2

2017-04-20 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/132 Small changes like this you can directly push to the `master` branch, opening PR and merging it, is time-consuming :) --- If your project is set up for it, you can reply to this email and have

[GitHub] struts pull request #131: WW-4210: Type conversion class

2017-04-20 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/131 WW-4210: Type conversion class This PR extends existing `TypeConversion` annotation to allow define converters as a class instead of a raw string. Implements

[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/130 This is ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] struts pull request #129: Support 2 3

2017-04-20 Thread gmcdonald
Github user gmcdonald closed the pull request at: https://github.com/apache/struts/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 I hope the regex is stable 😉 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] struts issue #131: WW-4210: Type conversion class

2017-04-20 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/131 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/130 > I hope the regex is stable What do you mean by that? I have used this http://www.regular-expressions.info/creditcard.html --- If your project is set up for it, you can reply to

[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 How often do credit card companies change their number-patterns in a way that the regex needs to be updated? 'guess it is rare enough. --- If your project is set up for it, you can reply to this

[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/130 Good question... I have used those random card numbers in tests and looks ok (but we will see) https://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm --- If your

[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 If patterns change users have another reason to upgrade to latest struts 😆 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If