[GitHub] [submarine] pingsutw commented on issue #179: SUBMARINE-377. [SDK] Submit a job by pysubamrine

2020-02-12 Thread GitBox
pingsutw commented on issue #179: SUBMARINE-377. [SDK] Submit a job by pysubamrine URL: https://github.com/apache/submarine/pull/179#issuecomment-585119393 Update patch. - remove pb2*.py that generated from protobuf - update readme

[GitHub] [submarine] pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread GitBox
pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585154100 There is an EditConfig file in `submarine-workbench/workbench-web/.editorconfig`, Do we need to

[GitHub] [submarine] jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread GitBox
jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#discussion_r378262508 ## File path: .editorconfig ## @@ -0,0 +1,25 @@ +# EditorConfig is

[GitHub] [submarine] jiwq edited a comment on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread GitBox
jiwq edited a comment on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585211977 > With this EditorConfig file, what settings need to be set in the development tool (e.g., IDEA)?

[GitHub] [submarine] jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread GitBox
jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#discussion_r378253807 ## File path: .editorconfig ## @@ -0,0 +1,25 @@ +# EditorConfig is

[GitHub] [submarine] jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread GitBox
jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585217039 > There is an EditConfig file in `submarine-workbench/workbench-web/.editorconfig`, Do we need to

[GitHub] [submarine] pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread GitBox
pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585223596 Okay. If it's not conflicted, I thought we don't need to change it. Thanks @jiwq. LGTM

[GitHub] [submarine] jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread GitBox
jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585211977 > With this EditorConfig file, what settings need to be set in the development tool (e.g., IDEA)?

[GitHub] [submarine] lowc1012 commented on issue #174: SUBMARINE-202. submarine core need to support MXNet

2020-02-12 Thread GitBox
lowc1012 commented on issue #174: SUBMARINE-202. submarine core need to support MXNet URL: https://github.com/apache/submarine/pull/174#issuecomment-585545961 @yuanzac, @pingsutw Thanks for your review. I have tested on my YARN cluster. Yes, we can submit MXNet job with this PR.

[jira] [Updated] (SUBMARINE-384) Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread Zac Zhou (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zac Zhou updated SUBMARINE-384: --- Fix Version/s: 0.4.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [submarine] yuanzac commented on issue #174: SUBMARINE-202. submarine core need to support MXNet

2020-02-12 Thread GitBox
yuanzac commented on issue #174: SUBMARINE-202. submarine core need to support MXNet URL: https://github.com/apache/submarine/pull/174#issuecomment-585521799 Any more comments? @lowc1012, @pingsutw, @liuxunorg, @tangzhankun

[jira] [Resolved] (SUBMARINE-323) Submarine release scripts

2020-02-12 Thread Zac Zhou (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zac Zhou resolved SUBMARINE-323. Fix Version/s: 0.4.0 Resolution: Fixed Issue resolved by pull request 175

[jira] [Work logged] (SUBMARINE-323) Submarine release scripts

2020-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-323?focusedWorklogId=386375=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386375 ] ASF GitHub Bot logged work on SUBMARINE-323: Author: ASF GitHub

[GitHub] [submarine] asfgit closed pull request #180: SUBMARINE-379. Delete invalid .gitmodules file

2020-02-12 Thread GitBox
asfgit closed pull request #180: SUBMARINE-379. Delete invalid .gitmodules file URL: https://github.com/apache/submarine/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (SUBMARINE-379) Delete invalid .gitmodules file

2020-02-12 Thread Liu Xun (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Xun resolved SUBMARINE-379. --- Fix Version/s: 0.4.0 Resolution: Fixed Issue resolved by pull request 180

[submarine] branch master updated: SUBMARINE-379. Delete invalid .gitmodules file

2020-02-12 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/submarine.git The following commit(s) were added to refs/heads/master by this push: new e03b08f SUBMARINE-379. Delete invalid

[jira] [Work logged] (SUBMARINE-379) Delete invalid .gitmodules file

2020-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-379?focusedWorklogId=386323=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386323 ] ASF GitHub Bot logged work on SUBMARINE-379: Author: ASF GitHub

[GitHub] [submarine] yuanzac commented on a change in pull request #179: SUBMARINE-377. [SDK] Submit a job by pysubamrine

2020-02-12 Thread GitBox
yuanzac commented on a change in pull request #179: SUBMARINE-377. [SDK] Submit a job by pysubamrine URL: https://github.com/apache/submarine/pull/179#discussion_r378623370 ## File path:

[jira] [Work logged] (SUBMARINE-384) Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-384?focusedWorklogId=386349=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386349 ] ASF GitHub Bot logged work on SUBMARINE-384: Author: ASF GitHub

[GitHub] [submarine] asfgit closed pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread GitBox
asfgit closed pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181 This is an automated message from the Apache Git Service.

[submarine] branch master updated: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess

2020-02-12 Thread zhouquan
This is an automated email from the ASF dual-hosted git repository. zhouquan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/submarine.git The following commit(s) were added to refs/heads/master by this push: new e3b5c5c SUBMARINE-384. Add EditorConfig

[GitHub] [submarine] asfgit closed pull request #175: SUBMARINE-323. Add how to release guide and scripts.

2020-02-12 Thread GitBox
asfgit closed pull request #175: SUBMARINE-323. Add how to release guide and scripts. URL: https://github.com/apache/submarine/pull/175 This is an automated message from the Apache Git Service. To respond to the message,

[submarine] branch master updated: SUBMARINE-323. Add how to release guide and scripts.

2020-02-12 Thread zhouquan
This is an automated email from the ASF dual-hosted git repository. zhouquan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/submarine.git The following commit(s) were added to refs/heads/master by this push: new 9cff5f4 SUBMARINE-323. Add how to release

[GitHub] [submarine] asfgit closed pull request #177: SUBMARINE-344. Support update submarine site in CICD image

2020-02-12 Thread GitBox
asfgit closed pull request #177: SUBMARINE-344. Support update submarine site in CICD image URL: https://github.com/apache/submarine/pull/177 This is an automated message from the Apache Git Service. To respond to the

[jira] [Work logged] (SUBMARINE-344) Add submarine site dockerfile

2020-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-344?focusedWorklogId=386370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386370 ] ASF GitHub Bot logged work on SUBMARINE-344: Author: ASF GitHub

[submarine] branch master updated: SUBMARINE-344. Support update submarine site in CICD image

2020-02-12 Thread zhouquan
This is an automated email from the ASF dual-hosted git repository. zhouquan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/submarine.git The following commit(s) were added to refs/heads/master by this push: new 39cbe9f SUBMARINE-344. Support update

[jira] [Resolved] (SUBMARINE-344) Add submarine site dockerfile

2020-02-12 Thread Zac Zhou (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zac Zhou resolved SUBMARINE-344. Fix Version/s: 0.4.0 Resolution: Fixed Issue resolved by pull request 177

[jira] [Updated] (SUBMARINE-323) Submarine release scripts

2020-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SUBMARINE-323: - Labels: pull-request-available (was: ) > Submarine release scripts >