Re: svn commit: r1803639 - in /subversion/trunk: build/run_tests.py subversion/libsvn_fs_fs/fs.h subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_fs_fs/transaction.c subversion/tests/cmdline/svntest/

2017-08-09 Thread Daniel Shahaf
Evgeny Kotkov wrote on Tue, 08 Aug 2017 17:05 +0300: > Perhaps, then, we could do all this as in the attached patch. +1, and thanks for the productive discussion :-).

errorcode.inc in tarballs

2017-08-09 Thread Philip Martin
I recently modified release.py and this has meant I have been recreating old tarballs to test my changes. This has highlighted the file subversion/libsvn_subr/errorcode.inc which is generated by gen-make.py, has content that is produced via Python's errno module with the result that the

Re: svn commit: r1804618 - /subversion/trunk/build/generator/gen_base.py

2017-08-09 Thread Daniel Shahaf
phi...@apache.org wrote on Thu, 10 Aug 2017 00:09 +: > +++ subversion/trunk/build/generator/gen_base.py Thu Aug 10 00:09:21 2017 > @@ -288,15 +288,21 @@ class GeneratorBase: > +# errno names can vary depending on the Python, and possibly the > +# OS, version and they are not even used

Re: svn commit: r1804618 - /subversion/trunk/build/generator/gen_base.py

2017-08-09 Thread Philip Martin
Daniel Shahaf writes: > Is this loop iteration style valid for empty arrays? Looking at C89, it's not > clear to me that sizeof(x[0]) is well-defined for empty arrays. It builds without warnings using 'gcc -std=c89' but fails if I add '-pedantic':