Re: [PATCH] Testcase for issue #4642

2016-11-17 Thread Stefan
On 11/17/2016 12:19, Stefan Sperling wrote: > On Thu, Nov 17, 2016 at 12:58:48AM +0100, Stefan wrote: >> Is there something else I'd do to improve the patch, or does anybody >> feel like approving it for commit? > +1 Thanks. Committed in r1770295. smime.p7s Description: S/MIME Cryptographic

Re: [PATCH] Testcase for issue #4642

2016-11-17 Thread Stefan Sperling
On Thu, Nov 17, 2016 at 12:58:48AM +0100, Stefan wrote: > Is there something else I'd do to improve the patch, or does anybody > feel like approving it for commit? +1

Re: [PATCH] Testcase for issue #4642

2016-11-16 Thread Stefan
On 11/8/2016 09:54, Stefan wrote: > On 10/18/2016 12:14, Daniel Shahaf wrote: >> Stefan Hett wrote on Tue, Oct 18, 2016 at 11:56:29 +0200: >>> Thanks for the review Daniel. Just a quick heads up that I'll get back to >>> this asap. Might take a few days until I can free up some time though. >>

Re: [PATCH] Testcase for issue #4642

2016-11-08 Thread Stefan
On 10/18/2016 12:14, Daniel Shahaf wrote: > Stefan Hett wrote on Tue, Oct 18, 2016 at 11:56:29 +0200: >> Thanks for the review Daniel. Just a quick heads up that I'll get back to >> this asap. Might take a few days until I can free up some time though. > Thanks for coordinating our expectations.

Re: [PATCH] Testcase for issue #4642

2016-10-18 Thread Daniel Shahaf
Stefan Hett wrote on Tue, Oct 18, 2016 at 11:56:29 +0200: > Thanks for the review Daniel. Just a quick heads up that I'll get back to > this asap. Might take a few days until I can free up some time though. Thanks for coordinating our expectations.

Re: [PATCH] Testcase for issue #4642

2016-10-18 Thread Stefan Hett
On 10/14/2016 8:53 PM, Daniel Shahaf wrote: Stefan wrote on Fri, Oct 14, 2016 at 17:30:57 +0200: Add an XFail test for issue #4642 (Setting depth to exclude for a path containing unversioned files requires a cleanup afterwards). Looks good overall. Just a few minor questions: +def

Re: [PATCH] Testcase for issue #4642

2016-10-14 Thread Daniel Shahaf
Stefan wrote on Fri, Oct 14, 2016 at 17:30:57 +0200: > Add an XFail test for issue #4642 (Setting depth to exclude for a path > containing unversioned files requires a cleanup afterwards). Looks good overall. Just a few minor questions: > +def fold_tree_with_unversioned_items(sbox): > +

[PATCH] Testcase for issue #4642

2016-10-14 Thread Stefan
Hi, following patch adds a test case for issue #4642: ""svn update --set-depth=exclude" exits prematurely, leaving repo in need of cleanup" [1]. [[[ Add an XFail test for issue #4642 (Setting depth to exclude for a path containing unversioned files requires a cleanup afterwards). *