Re: Buildbots: require Python-SQLite v3.8.2 [was: FSFS recovery should prune rep-cache even if its use is disabled]

2018-08-27 Thread Branko Čibej
On 27.08.2018 14:00, Daniel Shahaf wrote: > Branko Čibej wrote on Mon, 27 Aug 2018 13:44 +0200: >> On 24.08.2018 13:55, Julian Foad wrote: >>> Brane, this one's yours: >>> >>>   https://ci.apache.org/buildslaves/svn-x64-macosx-dgvrs >>> >>> The new tests for #4077 are failing on at least this

Re: Buildbots: require Python-SQLite v3.8.2 [was: FSFS recovery should prune rep-cache even if its use is disabled]

2018-08-27 Thread Daniel Shahaf
Branko Čibej wrote on Mon, 27 Aug 2018 13:44 +0200: > On 24.08.2018 13:55, Julian Foad wrote: > > Brane, this one's yours: > > > >   https://ci.apache.org/buildslaves/svn-x64-macosx-dgvrs > > > > The new tests for #4077 are failing on at least this buildbot-slave. > > > >   "Can't read rep-cache

Re: Buildbots: require Python-SQLite v3.8.2 [was: FSFS recovery should prune rep-cache even if its use is disabled]

2018-08-27 Thread Branko Čibej
On 24.08.2018 13:55, Julian Foad wrote: > Brane, this one's yours: > >   https://ci.apache.org/buildslaves/svn-x64-macosx-dgvrs > > The new tests for #4077 are failing on at least this buildbot-slave. > >   "Can't read rep-cache schema 2 using old Python-SQLite version (3, > 7, 13) < (3,8,2)" > >

Buildbots: require Python-SQLite v3.8.2 [was: FSFS recovery should prune rep-cache even if its use is disabled]

2018-08-24 Thread Julian Foad
Brane, this one's yours: https://ci.apache.org/buildslaves/svn-x64-macosx-dgvrs The new tests for #4077 are failing on at least this buildbot-slave. "Can't read rep-cache schema 2 using old Python-SQLite version (3, 7, 13) < (3,8,2)" (danielsh says: the magic number 3.8.2 is the minimum

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-24 Thread Daniel Shahaf
Julian Foad wrote on Fri, 24 Aug 2018 12:17 +0100: > Julian Foad: > > Committed in http://svn.apache.org/r1838813 > > And nominated for backport to 1.10.x and 1.9.x. > > The tests are failing on some buildbots: > > "Can't read rep-cache schema 2 using old Python-SQLite version (3, 7, > 13) <

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-24 Thread Julian Foad
Julian Foad: > Committed in http://svn.apache.org/r1838813 And nominated for backport to 1.10.x and 1.9.x. The tests are failing on some buildbots: "Can't read rep-cache schema 2 using old Python-SQLite version (3, 7, 13) < (3,8,2)" If we're using SQLite and want to have tests written in

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-24 Thread Julian Foad
Daniel Shahaf wrote: > Julian Foad wrote on Thu, Aug 23, 2018 at 10:21:17 +0100: > > +++ subversion/libsvn_fs_fs/recovery.c (working copy) > > @@ -468,15 +468,15 @@ recover_body(void *baton, apr_pool_t *po > >/* Prune younger-than-(newfound-youngest) revisions from the rep > > - cache

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-23 Thread Daniel Shahaf
Julian Foad wrote on Thu, Aug 23, 2018 at 10:21:17 +0100: > +++ subversion/libsvn_fs_fs/recovery.c(working copy) > @@ -468,15 +468,15 @@ recover_body(void *baton, apr_pool_t *po >/* Prune younger-than-(newfound-youngest) revisions from the rep > - cache if sharing is enabled taking

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-23 Thread Julian Foad
Proposed patch attached: prune-rep-cache-1.patch -- - Julian Let "svnadmin recover" prune the FSFS rep-cache even if it's not being used. Part of issue #4077 "FSFS recover should prune unborn revisions from rep-cache.db". This was included as r1213716 in the original fix for issue #4077, first

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-23 Thread Julian Foad
CC'ing Philip... Daniel Shahaf wrote: > Julian Foad wrote on Wed, 22 Aug 2018 22:20 +0100: > > Julian Foad wrote: > > > It looks like r1213716 ("also prune the rep-cache when it's present but > > > reportedly not being used") was reverted by r1367674, apparently > > > unintentionally. > > > >

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-22 Thread Daniel Shahaf
Julian Foad wrote on Wed, 22 Aug 2018 22:20 +0100: > Julian Foad wrote: > > It looks like r1213716 ("also prune the rep-cache when it's present but > > reportedly not being used") was reverted by r1367674, apparently > > unintentionally. > > Well, with some degree of intention, judging by the

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-22 Thread Julian Foad
Julian Foad wrote: > It looks like r1213716 ("also prune the rep-cache when it's present but > reportedly not being used") was reverted by r1367674, apparently > unintentionally. Well, with some degree of intention, judging by the code comment having been adjusted accordingly, but with no

FSFS recovery should prune rep-cache even if its use is disabled

2018-08-22 Thread Julian Foad
It looks like r1213716 ("also prune the rep-cache when it's present but reportedly not being used") was reverted by r1367674, apparently unintentionally. https://svn.apache.org/r1213716 (on 2011-12-13) > Follow-up to r1213681: also prune the rep-cache when it's present > but reportedly not