Re: [PATCH] Better error message for svn bindings import in mailer.py.

Karl Fogel wrote on Sat, Feb 17, 2018 at 16:52:39 -0600: > Daniel Shahaf writes: > >It would be useful to also print the caught exception in case it contains > >more > >specific information about the cause of the problem… > > > >… but in that case, why not remove the try/except entirely? > > Tha

Re: [PATCH] Better error message for svn bindings import in mailer.py.

Daniel Shahaf writes: >It would be useful to also print the caught exception in case it contains more >specific information about the cause of the problem… > >… but in that case, why not remove the try/except entirely? That's a good point. I already committed my original proposed change in r182

Re: [PATCH] Better error message for svn bindings import in mailer.py.

Karl Fogel wrote on Mon, 12 Feb 2018 15:04 -0600: > +++ tools/hook-scripts/mailer/mailer.py (working copy) > @@ -70,23 +70,21 @@ > _MIN_SVN_VERSION = [1, 5, 0] > > # Import the Subversion Python bindings, making sure they meet our > # minimum version requirements. > try: >import svn

Re: [PATCH] Better error message for svn bindings import in mailer.py.

On 2/12/2018 1:04 PM, Karl Fogel wrote: * tools/hook-scripts/mailer/mailer.py: If the Subversion Python bindings could not be found for import at all, have the error message state that clearly, instead of duplicating the error message used for importing too old a version of the bindings.

Re: [PATCH] Better error message for svn bindings import in mailer.py.

On 02/12/2018 04:04 PM, Karl Fogel wrote: > Hi all. I think one of the import error messages in > tools/hook-scripts/mailer/mailer.py is misleading (I discovered this while > debugging the problem that Troy Curtis Jr. solved in r1823802). Any > objections if I install this patch? > > [[[ > Giv