Re: [PATCH] Fix for SVN 1.8 with sqlite >= 3.12.0 and VS 2005+
On 18/11/2016 12:23, Stefan Hett wrote: > On 7/26/2016 12:13 AM, Stefan wrote: >> >> Hi, >> >> building SVN 1.8 using sqlite >= SQLite 3.12.0 (amalgamation) and VS >> 2005+ raises the following error: >> >> [...]\sqlite\sqlite3.c(42437): error C4013: 'rand_s' undefined; >> assuming extern returning int >> [[...]\1.8.16\build\win32\vcnet-vcproj\test_wc_queries.vcxproj] >> >> The issue does not exist in SVN != 1.8 as far as I see. Full details >> available here: http://www.luke1410.de:8090/browse/MAXSVN-58 >> >> The attached patch (based on the patch fixing the related issue in >> 1.7) resolves that by moving the sqlite3.c-include section to be >> first include statement in the file. >> >> If it's ok, I'll just add a 1.8 backport branch and nominate it for >> backporting to the 1.8-branch. >> >> Regards, >> Stefan >> > In light of the pending 1.8.16 I'd like to ping on this patch here. > Would be nice to get this in, since it breaks 1.8 builds with latest > sqlite on Windows atm. > > Should I create a 1.8-branch with this fix and just add it to 1.8 > STATUS so it can be voted for? > > -- > Regards, > Stefan Hett, Developer/Administrator > > EGOSOFT GmbH, Heidestrasse 4, 52146 Würselen, Germany > Tel: +49 2405 4239970, www.egosoft.com > Geschäftsführer: Bernd Lehahn, Handelsregister Aachen HRB 13473 FTR: As of SQLite 3.21.0 SQLite no longer uses rand_s. Therefore this patch won't be required with the latest SQLite versions anymore. Hence rejecting the patch suggestion (instead the install document should emphasize the compatibility issue). Regards, Stefan smime.p7s Description: S/MIME Cryptographic Signature
Re: [PATCH] Fix for SVN 1.8 with sqlite >= 3.12.0 and VS 2005+
Stefan wrote on Tue, Jul 26, 2016 at 00:13:55 +0200: > If it's ok, I'll just add a 1.8 backport branch and nominate it for > backporting to the 1.8-branch. For future reference: you don't need permission to create backport branches, nor to nominate them in STATUS. You can just create branches and nominate them (with a "+1 (non-binding)" vote), at any time. https://subversion.apache.org/docs/community-guide/general.html#lightweight-branches Cheers, Daniel
Re: [PATCH] Fix for SVN 1.8 with sqlite >= 3.12.0 and VS 2005+
Stefan wrote on Tue, Jul 26, 2016 at 00:13:55 +0200: > +++ subversion/tests/libsvn_wc/wc-queries-test.c (working copy) > @@ -21,14 +21,6 @@ > * > */ > > -#include "svn_pools.h" > -#include "svn_ctype.h" > -#include "private/svn_dep_compat.h" > - > -#include "svn_private_config.h" > - > -#include "../svn_test.h" > - > #ifdef SVN_SQLITE_INLINE >From IRC: Luke1410, on unix SVN_SQLITE_INLINE is defined in svn_private_config.h Luke1410, ... so it seems the patch would cause the #ifdef to false negative on unix in $circumstances (where $circumstances is "sqlite3 amalgamation is used") Cheers, Daniel
Re: [PATCH] Fix for SVN 1.8 with sqlite >= 3.12.0 and VS 2005+
On 7/26/2016 12:13 AM, Stefan wrote: Hi, building SVN 1.8 using sqlite >= SQLite 3.12.0 (amalgamation) and VS 2005+ raises the following error: [...]\sqlite\sqlite3.c(42437): error C4013: 'rand_s' undefined; assuming extern returning int [[...]\1.8.16\build\win32\vcnet-vcproj\test_wc_queries.vcxproj] The issue does not exist in SVN != 1.8 as far as I see. Full details available here: http://www.luke1410.de:8090/browse/MAXSVN-58 The attached patch (based on the patch fixing the related issue in 1.7) resolves that by moving the sqlite3.c-include section to be first include statement in the file. If it's ok, I'll just add a 1.8 backport branch and nominate it for backporting to the 1.8-branch. Regards, Stefan In light of the pending 1.8.16 I'd like to ping on this patch here. Would be nice to get this in, since it breaks 1.8 builds with latest sqlite on Windows atm. Should I create a 1.8-branch with this fix and just add it to 1.8 STATUS so it can be voted for? -- Regards, Stefan Hett, Developer/Administrator EGOSOFT GmbH, Heidestrasse 4, 52146 Würselen, Germany Tel: +49 2405 4239970, www.egosoft.com Geschäftsführer: Bernd Lehahn, Handelsregister Aachen HRB 13473
