Re: [PATCH] Remove unused variables in conflict resolution code

2016-10-12 Thread Patrick Steinhardt 
On Wed, Oct 12, 2016 at 03:46:38PM +0200, Ivan Zhakov wrote:
> On 12 October 2016 at 15:05, Patrick Steinhardt
>  wrote:
> > Hi,
> >
> > see the attached patch for fixes to some unused-variable
> > warnings.
> >
> > [[
> > Remove variables which are written but not used in any way.
> >
> > * subversion/libsvn_client/conflicts.c:
> >   Remove unused variables
> > ]]
> Hi, Patrick.
> 
> The log message should mention all affected functions/symbols. See
> 'Writing log messages' section in
> Community Guide [1]
> 
> [1] 
> https://subversion.apache.org/docs/community-guide/conventions.html#log-messages
> 
> -- 
> Ivan Zhakov

Hi,

here's the updated commit message. Thanks for reviewing.

[[
Remove variables which are written but not used in any way.

* subversion/libsvn_client/conflicts.c:
  (conflict_tree_get_incoming_description_generic,
   conflict_tree_get_description_incoming_edit,
   resolve_incoming_move_dir_merge,
   configure_option_incoming_delete_accept,
   configure_option_incoming_move_file_merge,
   configure_option_incoming_dir_merge): Remove unused variables
]]

Regards
-- 
Patrick Steinhardt, Entwickler

elego Software Solutions GmbH, http://www.elego.de
Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany

Sitz der Gesellschaft: Berlin, USt-IdNr.: DE 163214194
Handelsregister: Amtsgericht Charlottenburg HRB 77719
Geschäftsführer: Olaf Wagner


signature.asc
Description: PGP signature

Re: [PATCH] Remove unused variables in conflict resolution code

2016-10-12 Thread Ivan Zhakov 
On 12 October 2016 at 15:05, Patrick Steinhardt
 wrote:
> Hi,
>
> see the attached patch for fixes to some unused-variable
> warnings.
>
> [[
> Remove variables which are written but not used in any way.
>
> * subversion/libsvn_client/conflicts.c:
>   Remove unused variables
> ]]
Hi, Patrick.

The log message should mention all affected functions/symbols. See
'Writing log messages' section in
Community Guide [1]

[1] 
https://subversion.apache.org/docs/community-guide/conventions.html#log-messages

-- 
Ivan Zhakov