Re: Warnings from the bindings

2018-04-07 Thread Branko Čibej
On 07.04.2018 21:20, Philip Martin wrote: > Branko Čibej writes: > >> I'll take another look. At the very least this should be using the local >> frame manager object, which is exception-safe, unlike explicitly pushing >> and popping the frame. > ImmutableList::for_each iterates and constructs arb

Re: Warnings from the bindings

2018-04-07 Thread Philip Martin
Branko Čibej writes: > I'll take another look. At the very least this should be using the local > frame manager object, which is exception-safe, unlike explicitly pushing > and popping the frame. ImmutableList::for_each iterates and constructs arbitrary types T. The problem occurs when T is Ext

Re: Warnings from the bindings

2018-04-07 Thread Branko Čibej
On 07.04.2018 00:25, Philip Martin wrote: > Philip Martin writes: > >>Iterator iter(get_iterator()); >>while (iter.has_next()) >> + { >> +m_env.PushLocalFrame(10); >> function(T(m_env, NativeT(iter.next(; >> +m_env.PopLocalFrame(); >> + } >>

Re: Warnings from the bindings

2018-04-06 Thread Philip Martin
Philip Martin writes: >Iterator iter(get_iterator()); >while (iter.has_next()) > + { > +m_env.PushLocalFrame(10); > function(T(m_env, NativeT(iter.next(; > +m_env.PopLocalFrame(); > + } >return function; Rewriting as: while (i

Re: Warnings from the bindings

2018-04-06 Thread Philip Martin
Philip Martin writes: > Branko Čibej writes: > >> And I don't see these, either. I checked the code and we explicitly use >> a JNI local frame in the core loop of unparseExternals. Try as I might, >> I can't see where all those local references could be coming from. > > ImmutableList::for_each a

Re: Warnings from the bindings

2018-04-06 Thread Philip Martin
Branko Čibej writes: > And I don't see these, either. I checked the code and we explicitly use > a JNI local frame in the core loop of unparseExternals. Try as I might, > I can't see where all those local references could be coming from. ImmutableList::for_each appears to be the problem. The fo

Re: Warnings from the bindings

2018-04-03 Thread Branko Čibej
On 03.04.2018 13:28, Stefan Fuhrmann wrote: > On 30.03.2018 00:27, Philip Martin wrote: > >> WARNING in native method: JNI call made without checking exceptions when >> required to from CallStaticObjectMethod > Seen these in alpha2 but not in rc2. Java8 has > been updated since then. I don't se

Re: Warnings from the bindings

2018-04-03 Thread Stefan Fuhrmann
On 30.03.2018 00:27, Philip Martin wrote: Philip Martin writes: +1 to release The swig-pl tests produce warnings for: Warning: unable to close filehandle $out_fh properly: Bad file descriptor at /home/pm/sw/subversion/sign/build/subversion/bindings/swig/perl/native/blib/lib/SVN/Core.pm

Re: Warnings from the bindings

2018-03-30 Thread James McCoy
On Fri, Mar 30, 2018 at 09:29:47AM +0200, Branko Čibej wrote: > On 30.03.2018 00:27, Philip Martin wrote: > > Philip Martin writes: > > > >> +1 to release > > The swig-pl tests produce warnings for: > > > > Warning: unable to close filehandle $out_fh properly: Bad file descriptor > > at > > /h

Re: Warnings from the bindings

2018-03-30 Thread Philip Martin
Philip Martin writes: > WARNING in native method: JNI call made without checking exceptions > when required to from CallStaticObjectMethod > > but it's not clear to me which bit of source code is responsible. This might be a false alarm. From https://github.com/dropbox/djinni/issues/152#issuec

Re: Warnings from the bindings

2018-03-30 Thread Philip Martin
Stefan Sperling writes: > On Fri, Mar 30, 2018 at 09:29:47AM +0200, Branko Čibej wrote: >> I've never seen either of these warnings and I don't see what could've >> changed on the 1.10.x branch to make them suddenly start appearing. > > The Perl one happens on OpenBSD as well. It is not new. I do

Re: Warnings from the bindings

2018-03-30 Thread Stefan Sperling
On Fri, Mar 30, 2018 at 09:29:47AM +0200, Branko Čibej wrote: > On 30.03.2018 00:27, Philip Martin wrote: > > Philip Martin writes: > > > >> +1 to release > > The swig-pl tests produce warnings for: > > > > Warning: unable to close filehandle $out_fh properly: Bad file descriptor > > at > > /h

Re: Warnings from the bindings

2018-03-30 Thread Branko Čibej
On 30.03.2018 00:27, Philip Martin wrote: > Philip Martin writes: > >> +1 to release > The swig-pl tests produce warnings for: > > Warning: unable to close filehandle $out_fh properly: Bad file descriptor at > /home/pm/sw/subversion/sign/build/subversion/bindings/swig/perl/native/blib/lib/SVN/C