On 08.06.2018 00:30, Branko Čibej wrote:
Just FYI: in that case svn would have a requirement for NTFS. Because
both hard links (for files) and junctions (for directories) only work
on NTFS. So it wouldn't be possible anymore to use svn on e.g. a usb
stick formatted with FAT32.
Yes ... we'd
Branko Čibej writes:
>> We do use that flag, but — just like cross-device copies on Unix — the
>> move is no longer atomic, which could break the working copy quite badly.
>
> I mean cross-device moves, of course, not copies.
svn_io_file_move() is our wrapper that is intended to make it work:
On 08.06.2018 00:30, Branko Čibej wrote:
> On 07.06.2018 18:50, Stefan Kueng wrote:
>>
>> On 05.06.2018 23:35, Philip Martin wrote:
>>> Stefan Küng writes:
>>>
Index: subversion/libsvn_subr/io.c
===
---
Stefan Küng writes:
> Index: subversion/libsvn_subr/io.c
> ===
> --- subversion/libsvn_subr/io.c (revision 1831874)
> +++ subversion/libsvn_subr/io.c (working copy)
> @@ -342,8 +342,11 @@
>/* Not using svn_io_stat()
On Sat, May 26, 2018 at 7:35 AM Stefan Küng wrote:
> Next try, patch attached.
> Basically what this does is to never check for soft/hard links on Windows
> ever. Since Subversion doesn't really handle those on Windows anyway,
> checking for them doesn't make sense and causes problems.
>
> I've
on a Windows build?
>>>
>>> If e.g. svn_io_check_special_path() on Windows would always return
>>> false and svn_io_check_path() always call svn_io_check_resolved_path()
>>> instead, this would work fine with the reparse points on Windows.
>>>
>
ork on
>> Windows. At least the docs state that they're not handled on Windows.
>> So why do we even check for 'special' nodes on a Windows build?
>>
>> If e.g. svn_io_check_special_path() on Windows would always return
>> false and svn_io_check_path() always call svn_io_ch
eck_special_path() on Windows would always return
> false and svn_io_check_path() always call svn_io_check_resolved_path()
> instead, this would work fine with the reparse points on Windows.
>
> So is there a reason why this is not done so on Windows? Is there
> maybe a reason for handli
for 'special' nodes on a Windows build?
>
> If e.g. svn_io_check_special_path() on Windows would always return false
> and svn_io_check_path() always call svn_io_check_resolved_path()
> instead, this would work fine with the reparse points on Windows.
>
> So is there a reason why this is not done
s on
> > a Onedrive folder.
> >
> > See here for more details:
> > https://groups.google.com/d/msg/tortoisesvn/hlQj5OifhBg/RX_cw_sQCgAJ
> >
> > While in this particular situation, other svn clients are not affected,
> > it still means that there's a problem
, other svn clients are not affected,
it still means that there's a problem.
I've attached a patch for handling reparse points better when detecting
and reading the working copy database. With this change, the TSVN
context menu shows up properly.
But while I was trying to figure out
11 matches
Mail list logo