Re: [dev] [st] Add a newline to the string printed in die
Am 11.12.2012 um 12:38 schrieb Marc Andre Tanner m...@brain-dump.org: Please send patches as attached files. Since we are using now git, it is easier and logic send the patches in this way, so the code of the patch can be included and modified in replies. You only have to use git am if you want to incorpore then to the main repository ,and it will keep the correct author and commiter, that I can see this information is lost now (I think it is not the correct way put a 'thanks' in the commit message). I won’t accept such patches. Please send attached files. I won’t imple‐ ment the outdated mbox or Maildir format for this. That is retarded. Inline patches which facilitate commenting are the prefered patch format. Get familiar with your git tools. I agree and while there, maybe learn to use your MUA as well. Regards, Joerg
Re: [dev] [st] Add a newline to the string printed in die
Am 11.12.2012 um 18:34 schrieb Christoph Lohmann 2...@r-36.net: I don’t know why people prefer to see the big patches inline, Ideally the patches are small :) so you have the scroll past the whole patch to the next e‐mail, when you are So, scrolling is a problem for you? I do shift+g usually. using a pager to read your e‐mail. What? May I suggest to start learning how to use a MUA and the according Editor? It’s easier when the MUA is filtering the patch file out, by simply showing, that some properly formatted patch is attached, which you can download, What? Download the patch? In what retarded way are you accessing mails? Even if MIME sucks, It sucks. People don’t know how to properly format e‐mails, so they will toppost on top of long patches and simply attach the whole thing. Whats wrong with having patch again in the reply at the bottom? Regards, Joerg
Re: [dev] [st] Add a newline to the string printed in die
Greetings. On Tue, 11 Dec 2012 09:40:16 +0100 Roberto E. Vargas Caballero k...@shike2.com wrote: After a call to die the program exits and the shell take the control, so it is better for the user the shell begins in an new line, and it is better for the programmer don't have to explicitly add it in each call to die. No, this will change the die() behaviour between all suckless projects. Rejected. Please send patches as attached files. Sincerely, Christoph Lohmann
Re: [dev] [st] Add a newline to the string printed in die
No, this will change the die() behaviour between all suckless projects. Then, change die in all the projects, it is the usual way of working with other issues, no? Please send patches as attached files. Since we are using now git, it is easier and logic send the patches in this way, so the code of the patch can be included and modified in replies. You only have to use git am if you want to incorpore then to the main repository ,and it will keep the correct author and commiter, that I can see this information is lost now (I think it is not the correct way put a 'thanks' in the commit message). Best regards,
Re: [dev] [st] Add a newline to the string printed in die
Greetings. On Tue, 11 Dec 2012 10:39:55 +0100 Roberto E. Vargas Caballero k...@shike2.com wrote: No, this will change the die() behaviour between all suckless projects. Then, change die in all the projects, it is the usual way of working with other issues, no? Why should your taste change all the behaviour of die() in all suckless projects? Appending the \n by the programmer adds flexibility, so there is no need to write a die‐no‐newline() function. Please send patches as attached files. Since we are using now git, it is easier and logic send the patches in this way, so the code of the patch can be included and modified in replies. You only have to use git am if you want to incorpore then to the main repository ,and it will keep the correct author and commiter, that I can see this information is lost now (I think it is not the correct way put a 'thanks' in the commit message). I won’t accept such patches. Please send attached files. I won’t imple‐ ment the outdated mbox or Maildir format for this. Sincerely, Christoph Lohmann
Re: [dev] [st] Add a newline to the string printed in die
On Tue, Dec 11, 2012 at 10:39:55AM +0100, Christoph Lohmann wrote: Please send patches as attached files. Since we are using now git, it is easier and logic send the patches in this way, so the code of the patch can be included and modified in replies. You only have to use git am if you want to incorpore then to the main repository ,and it will keep the correct author and commiter, that I can see this information is lost now (I think it is not the correct way put a 'thanks' in the commit message). I won’t accept such patches. Please send attached files. I won’t imple‐ ment the outdated mbox or Maildir format for this. That is retarded. Inline patches which facilitate commenting are the prefered patch format. Get familiar with your git tools. Marc -- Marc Andre Tanner http://www.brain-dump.org/ GPG key: CF7D56C0
Re: [dev] [st] Add a newline to the string printed in die
Greetings. On Tue, 11 Dec 2012 18:25:04 +0100 Marc Andre Tanner m...@brain-dump.org wrote: On Tue, Dec 11, 2012 at 10:39:55AM +0100, Christoph Lohmann wrote: Please send patches as attached files. Since we are using now git, it is easier and logic send the patches in this way, so the code of the patch can be included and modified in replies. You only have to use git am if you want to incorpore then to the main repository ,and it will keep the correct author and commiter, that I can see this information is lost now (I think it is not the correct way put a 'thanks' in the commit message). I won’t accept such patches. Please send attached files. I won’t imple‐ ment the outdated mbox or Maildir format for this. That is retarded. Inline patches which facilitate commenting are the prefered patch format. Get familiar with your git tools. No. Sincerely, Christoph Lohmann
Re: [dev] [st] Add a newline to the string printed in die
On Tue, Dec 11, 2012 at 06:25:04PM +0100, Christoph Lohmann wrote: Greetings. On Tue, 11 Dec 2012 18:25:04 +0100 Marc Andre Tanner m...@brain-dump.org wrote: On Tue, Dec 11, 2012 at 10:39:55AM +0100, Christoph Lohmann wrote: Please send patches as attached files. Since we are using now git, it is easier and logic send the patches in this way, so the code of the patch can be included and modified in replies. You only have to use git am if you want to incorpore then to the main repository ,and it will keep the correct author and commiter, that I can see this information is lost now (I think it is not the correct way put a 'thanks' in the commit message). I won’t accept such patches. Please send attached files. I won’t imple‐ ment the outdated mbox or Maildir format for this. That is retarded. Inline patches which facilitate commenting are the prefered patch format. Get familiar with your git tools. No. Ah, I just got onto this thread..maybe this is why my patch: [PATCHv2] dwm: replace deprecated XKeycodeToKeysym had not been reviewed/commented? :) Cheers, -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto Che Guevara pgpDfwirSxUrd.pgp Description: PGP signature
Re: [dev] [st] Add a newline to the string printed in die
Greetings. On Tue, 11 Dec 2012 18:34:19 +0100 Antonio Quartulli or...@autistici.org wrote: On Tue, Dec 11, 2012 at 06:25:04PM +0100, Christoph Lohmann wrote: Greetings. On Tue, 11 Dec 2012 18:25:04 +0100 Marc Andre Tanner m...@brain-dump.org wrote: On Tue, Dec 11, 2012 at 10:39:55AM +0100, Christoph Lohmann wrote: Please send patches as attached files. Since we are using now git, it is easier and logic send the patches in this way, so the code of the patch can be included and modified in replies. You only have to use git am if you want to incorpore then to the main repository ,and it will keep the correct author and commiter, that I can see this information is lost now (I think it is not the correct way put a 'thanks' in the commit message). I won’t accept such patches. Please send attached files. I won’t imple‐ ment the outdated mbox or Maildir format for this. That is retarded. Inline patches which facilitate commenting are the prefered patch format. Get familiar with your git tools. No. Ah, I just got onto this thread..maybe this is why my patch: [PATCHv2] dwm: replace deprecated XKeycodeToKeysym had not been reviewed/commented? :) No, Anselm is the maintainer of dwm. He needs some time to answer your patch. For the thread: I don’t know why people prefer to see the big patches inline, so you have the scroll past the whole patch to the next e‐mail, when you are using a pager to read your e‐mail. It’s easier when the MUA is filtering the patch file out, by simply showing, that some properly formatted patch is attached, which you can download, view in your favourite editor and apply it with git apply. This also allows to do easier prefiltering in your mailcap file, without having to scan all e‐mails with heuris‐ tics. Even if MIME sucks, it’s shorter to use the proper MIME type in‐ stead of filtering whole e‐mail blocks. People don’t know how to properly format e‐mails, so they will toppost on top of long patches and simply attach the whole thing. This is just a preliminary filter, so you can configure your MUA to not show everything. And that’s why I am against inline patches. It was a hard fight to allow proper attachments, now use them. It was a hard fight to have UTF‐8 and 8bit e‐mails too, but that fight is at least won. Now for the next fight. Sincerely, Christoph Lohmann
Re: [dev] [st] Add a newline to the string printed in die
On 11 December 2012 18:33, Antonio Quartulli or...@autistici.org wrote: On Tue, Dec 11, 2012 at 06:25:04PM +0100, Christoph Lohmann wrote: On Tue, 11 Dec 2012 18:25:04 +0100 Marc Andre Tanner m...@brain-dump.org wrote: On Tue, Dec 11, 2012 at 10:39:55AM +0100, Christoph Lohmann wrote: Please send patches as attached files. Since we are using now git, it is easier and logic send the patches in this way, so the code of the patch can be included and modified in replies. You only have to use git am if you want to incorpore then to the main repository ,and it will keep the correct author and commiter, that I can see this information is lost now (I think it is not the correct way put a 'thanks' in the commit message). I won’t accept such patches. Please send attached files. I won’t imple‐ ment the outdated mbox or Maildir format for this. That is retarded. Inline patches which facilitate commenting are the prefered patch format. Get familiar with your git tools. No. Ah, I just got onto this thread..maybe this is why my patch: [PATCHv2] dwm: replace deprecated XKeycodeToKeysym had not been reviewed/commented? :) We had a similar patch already which I first applied and then reverted to the old XKeycodeToKeysym() call, as it would require cumbersome fallback behavior to XKeycoceToKeysym() on older X servers. Cheers, Anselm
