[GitHub] lxzhangchao commented on issue #3220: Js translation

lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-320504299 Is there any way to get Superset current language in the JS file, to be able to compile it?

[GitHub] RemiTurpaud commented on issue #2321: get_sqla_engine in models.py should save and reuse engine across requests

RemiTurpaud commented on issue #2321: get_sqla_engine in models.py should save and reuse engine across requests URL: https://github.com/apache/incubator-superset/issues/2321#issuecomment-320512406 Another impact of this behavior seems to be that DB sessions remain opened, until closed by

[DRAFT] Incubator PMC Board Report - August 2017

All, Below please find the report in draft. There are 4 podlings not reporting thus far, and six podlings missing sign off. Please review at your earliest convenience. I have CC'd the ten podlings. John Incubator PMC report for August 2017 The Apache Incubator is the entry path into th

[GitHub] mistercrunch closed pull request #3246: Fix typo

mistercrunch closed pull request #3246: Fix typo URL: https://github.com/apache/incubator-superset/pull/3246 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] mistercrunch commented on issue #2321: get_sqla_engine in models.py should save and reuse engine across requests

mistercrunch commented on issue #2321: get_sqla_engine in models.py should save and reuse engine across requests URL: https://github.com/apache/incubator-superset/issues/2321#issuecomment-320562107 Agreed, we should use `NullPool` for queries -

[GitHub] mistercrunch commented on issue #2321: get_sqla_engine in models.py should save and reuse engine across requests

mistercrunch commented on issue #2321: get_sqla_engine in models.py should save and reuse engine across requests URL: https://github.com/apache/incubator-superset/issues/2321#issuecomment-320562268 I'm not sure if we have instance of calling create_engine twice in a single web request, bu

[GitHub] mistercrunch commented on issue #3073: Filter box triggers multiple queries for each filter control

mistercrunch commented on issue #3073: Filter box triggers multiple queries for each filter control URL: https://github.com/apache/incubator-superset/issues/3073#issuecomment-320563064 Actually it has to run multiple queries as the metric may not be additive (count distinct for instance).

[GitHub] mistercrunch commented on issue #3243: Nested columns not visible when connecting to prestoDB

mistercrunch commented on issue #3243: Nested columns not visible when connecting to prestoDB URL: https://github.com/apache/incubator-superset/issues/3243#issuecomment-320563641 Yes we use pyhive. We're committed to allow to go around the lowest common denominator issue with SQLAlchemy.

[GitHub] mistercrunch commented on issue #3242: Make sql editor resizable

mistercrunch commented on issue #3242: Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-320565672 I pulled the branch and tried it. It mostly works but it's a little funky. We went from single-page app to no-quite that where there's one too

[GitHub] mistercrunch commented on issue #3242: Make sql editor resizable

mistercrunch commented on issue #3242: Make sql editor resizable URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-320565875 I'd also like to have a minimum height constraint on the SQL editor, so that users can't get confused as to it completely disappearing.

[GitHub] coveralls commented on issue #3244: [explore] make edit datasource a basic link

coveralls commented on issue #3244: [explore] make edit datasource a basic link URL: https://github.com/apache/incubator-superset/pull/3244#issuecomment-320567079 [](https://coveralls.io/builds/12717914) Coverage rema

[GitHub] coveralls commented on issue #3244: [explore] make edit datasource a basic link

coveralls commented on issue #3244: [explore] make edit datasource a basic link URL: https://github.com/apache/incubator-superset/pull/3244#issuecomment-320567082 [](https://coveralls.io/builds/12717914) Coverage rema

[GitHub] coveralls commented on issue #3244: [explore] make edit datasource a basic link

coveralls commented on issue #3244: [explore] make edit datasource a basic link URL: https://github.com/apache/incubator-superset/pull/3244#issuecomment-320567080 [](https://coveralls.io/builds/12717914) Coverage rema