[GitHub] alanmcruickshank commented on issue #3821: Group the dashboards into Folders when there are too many to view.

2017-11-17 Thread GitBox
alanmcruickshank commented on issue #3821: Group the dashboards into Folders when there are too many to view. URL: https://github.com/apache/incubator-superset/issues/3821#issuecomment-345227716 @graceguo-supercat I love the idea of tagging, rather than tabs or folders. That would

[GitHub] alanmcruickshank commented on issue #3884: Please add one column in the ?add Slices to Dashboard? Pop-up window

2017-11-17 Thread GitBox
alanmcruickshank commented on issue #3884: Please add one column in the ?add Slices to Dashboard? Pop-up window URL: https://github.com/apache/incubator-superset/issues/3884#issuecomment-345229061 @luciuschina - I can have a crack at this one.

[GitHub] gdeepali commented on issue #1996: Custom SQL queries with filters

2017-11-17 Thread GitBox
gdeepali commented on issue #1996: Custom SQL queries with filters URL: https://github.com/apache/incubator-superset/issues/1996#issuecomment-345181747 Is it possible to get current logged in user using jinja templates? For example, I want to do something like SELECT * FROM tbl

[GitHub] xrmx commented on issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gunicorn

2017-11-17 Thread GitBox
xrmx commented on issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gunicorn URL: https://github.com/apache/incubator-superset/issues/3894#issuecomment-345180657 Could you reproduce without a gevent worker?

[GitHub] xrmx commented on issue #3898: How to use a count metric in Superset?

2017-11-17 Thread GitBox
xrmx commented on issue #3898: How to use a count metric in Superset? URL: https://github.com/apache/incubator-superset/issues/3898#issuecomment-345180401 Nope, you do it manually or you script it. This is an automated

[GitHub] xrmx commented on issue #3881: [linting] Cleaning up linting documentation

2017-11-17 Thread GitBox
xrmx commented on issue #3881: [linting] Cleaning up linting documentation URL: https://github.com/apache/incubator-superset/pull/3881#issuecomment-345180026 I suspect not many people run tox on their machine, but just rely on CI. Either way it's good for me.

[GitHub] alanmcruickshank opened a new pull request #3900: Add datasource to the SliceAddView modal (#3884)

2017-11-17 Thread GitBox
alanmcruickshank opened a new pull request #3900: Add datasource to the SliceAddView modal (#3884) URL: https://github.com/apache/incubator-superset/pull/3900 Fix for issue #3884 adding datasource to the "Add Slice" modal on the dashboard view.

[GitHub] john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345333095 @Mogball per @xrmx's comment in the issue this may actually be a Gevent issue. I'm not certain whether we want

[GitHub] john-bodley commented on issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gevent with Gunicorn

2017-11-17 Thread GitBox
john-bodley commented on issue #3894: Scanning or Refreshing Druid Datasource fails whilst using Gevent with Gunicorn URL: https://github.com/apache/incubator-superset/issues/3894#issuecomment-345332631 @xrmx it seems like this is actually a Gevent issue as opposed to Gunicorn. I'm

[GitHub] graceguo-supercat closed pull request #3893: Only refreshing non instant filters on apply

2017-11-17 Thread GitBox
graceguo-supercat closed pull request #3893: Only refreshing non instant filters on apply URL: https://github.com/apache/incubator-superset/pull/3893 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] xrmx commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
xrmx commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345359353 If you are just waiting on druid threads instead of processes should be fine. To avoid the possible creation of ton of

[GitHub] xrmx commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
xrmx commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345359353 If you are just waiting on druid IO threads instead of processes should be fine. To avoid the possible creation of ton

[GitHub] john-bodley commented on issue #3583: [3541] Augmenting datasources uniqueness constraints

2017-11-17 Thread GitBox
john-bodley commented on issue #3583: [3541] Augmenting datasources uniqueness constraints URL: https://github.com/apache/incubator-superset/pull/3583#issuecomment-345424552 @mistercrunch I've resolve all the merge conflicts.

[GitHub] Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345418884 `latest_metadata` doesn't make any calls to SQLAlchemy ?

[GitHub] john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
john-bodley commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345404884 @mistercrunch @Mogball @xrmx I'm not overly familiar with this portion of the code base, and the interactions

[GitHub] Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345406215 The speed up is more than just 4x (or whatever the number of available threads). Most of the time is spent waiting

[GitHub] Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
Mogball commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345406215 The speed up is more than just 4x (or whatever the number of available threads). Most of the time is spent waiting

[GitHub] Mogball commented on a change in pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-17 Thread GitBox
Mogball commented on a change in pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897#discussion_r151822485 ## File path: superset/connectors/druid/models.py ## @@ -563,11

[GitHub] michellethomas commented on issue #3890: [dashboard bug]Instant control should take effect instantly

2017-11-17 Thread GitBox
michellethomas commented on issue #3890: [dashboard bug]Instant control should take effect instantly URL: https://github.com/apache/incubator-superset/pull/3890#issuecomment-345400997 lgtm This is an automated message from

[GitHub] graceguo-supercat closed pull request #3890: [dashboard bug]Instant control should take effect instantly

2017-11-17 Thread GitBox
graceguo-supercat closed pull request #3890: [dashboard bug]Instant control should take effect instantly URL: https://github.com/apache/incubator-superset/pull/3890 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] john-bodley commented on issue #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-17 Thread GitBox
john-bodley commented on issue #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897#issuecomment-345403832 @Mogball I updated the logic to revert to the current time. @mistercrunch I went through the code to

[GitHub] mistercrunch closed pull request #3879: Allow users to specify label->color mapping

2017-11-17 Thread GitBox
mistercrunch closed pull request #3879: Allow users to specify label->color mapping URL: https://github.com/apache/incubator-superset/pull/3879 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] john-bodley commented on a change in pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-17 Thread GitBox
john-bodley commented on a change in pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897#discussion_r151827678 ## File path: superset/connectors/druid/models.py ## @@ -563,11

[GitHub] liuzn4ever commented on issue #3656: Export Dashboard doesn't work

2017-11-17 Thread GitBox
liuzn4ever commented on issue #3656: Export Dashboard doesn't work URL: https://github.com/apache/incubator-superset/issues/3656#issuecomment-345416549 A page is intercepted by the browser ,you can use the Edge of win10?then you can download the dashboard file,and its suffix name is

[GitHub] mistercrunch closed pull request #3899: [druid] Renaming refresh_async method

2017-11-17 Thread GitBox
mistercrunch closed pull request #3899: [druid] Renaming refresh_async method URL: https://github.com/apache/incubator-superset/pull/3899 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mistercrunch closed pull request #3900: Add datasource to the SliceAddView modal (#3884)

2017-11-17 Thread GitBox
mistercrunch closed pull request #3900: Add datasource to the SliceAddView modal (#3884) URL: https://github.com/apache/incubator-superset/pull/3900 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch commented on a change in pull request #3892: [Bugfix]: Subquery time filter logic for sqla datasources (partitions)

2017-11-17 Thread GitBox
mistercrunch commented on a change in pull request #3892: [Bugfix]: Subquery time filter logic for sqla datasources (partitions) URL: https://github.com/apache/incubator-superset/pull/3892#discussion_r151828077 ## File path: superset/connectors/sqla/models.py ## @@

[GitHub] mistercrunch closed pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary

2017-11-17 Thread GitBox
mistercrunch closed pull request #3897: [druid] Catch IOError when fetching Druid datasource time boundary URL: https://github.com/apache/incubator-superset/pull/3897 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] mistercrunch commented on issue #1996: Custom SQL queries with filters

2017-11-17 Thread GitBox
mistercrunch commented on issue #1996: Custom SQL queries with filters URL: https://github.com/apache/incubator-superset/issues/1996#issuecomment-345417447 more like: ``` SELECT * FROM tbl WHERE uername = '{{ current_username() }}' ```

[GitHub] mistercrunch commented on issue #3891: [BUGFIX]: Fixing dttm_sql_literal to use python_date_format

2017-11-17 Thread GitBox
mistercrunch commented on issue #3891: [BUGFIX]: Fixing dttm_sql_literal to use python_date_format URL: https://github.com/apache/incubator-superset/pull/3891#issuecomment-345417893 Travis never fired for this one, maybe pushing a new commit on top will trigger it?

[GitHub] mistercrunch commented on issue #3861: overlap of Legends with the ToolTip

2017-11-17 Thread GitBox
mistercrunch commented on issue #3861: overlap of Legends with the ToolTip URL: https://github.com/apache/incubator-superset/pull/3861#issuecomment-345417995 Sorry I meant of snapshot of what the visualization looks like not the code.

[GitHub] mistercrunch commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn

2017-11-17 Thread GitBox
mistercrunch commented on issue #3895: [druid] Fixing issue 3894 multi-processing w/ Gunicorn URL: https://github.com/apache/incubator-superset/pull/3895#issuecomment-345418062 Heads up that there are caveats with thread-safety around SQLAlchemy