[GitHub] mistercrunch commented on issue #4371: Mapbox isn't working on Druid

mistercrunch commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-363862350 Looks like a problem around handling a Druid postaggregation that references a metric or post agg that doesn't exist. Would be nice to

[GitHub] maver1ck opened a new issue #4370: Two user profile pages - let's make it one

maver1ck opened a new issue #4370: Two user profile pages - let's make it one URL: https://github.com/apache/incubator-superset/issues/4370 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superset logs for python stacktraces and

[GitHub] mistercrunch closed pull request #4367: Remove useless empty npm-debug.log

mistercrunch closed pull request #4367: Remove useless empty npm-debug.log URL: https://github.com/apache/incubator-superset/pull/4367 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] SpyderRivera opened a new issue #4371: Mapbox isn't working on Druid

SpyderRivera opened a new issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included

[GitHub] mistercrunch commented on issue #2873: Connecting Superset to Kerberized Hive with Pyhive

mistercrunch commented on issue #2873: Connecting Superset to Kerberized Hive with Pyhive URL: https://github.com/apache/incubator-superset/issues/2873#issuecomment-363821816 MR Hive. Haven't used LLAP Hive. This is an

[GitHub] mistercrunch commented on issue #2873: Connecting Superset to Kerberized Hive with Pyhive

mistercrunch commented on issue #2873: Connecting Superset to Kerberized Hive with Pyhive URL: https://github.com/apache/incubator-superset/issues/2873#issuecomment-363821816 MR Hive just because it's so slow. Haven't used LLAP Hive.

[GitHub] mistercrunch closed pull request #4319: convert postgresql date_trunc() to UTC to prevent pandas error

mistercrunch closed pull request #4319: convert postgresql date_trunc() to UTC to prevent pandas error URL: https://github.com/apache/incubator-superset/pull/4319 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] mistercrunch closed pull request #4368: Add ipdb to dev dependencies.

mistercrunch closed pull request #4368: Add ipdb to dev dependencies. URL: https://github.com/apache/incubator-superset/pull/4368 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mistercrunch closed pull request #4358: [druid] fix bug around handling NULLs

mistercrunch closed pull request #4358: [druid] fix bug around handling NULLs URL: https://github.com/apache/incubator-superset/pull/4358 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] xrmx commented on issue #4371: Mapbox isn't working on Druid

xrmx commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-363823874 Is this a build from git or a release? In the first case the git hash is more helpful than the version written in the source.

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-363823781 

[GitHub] mistercrunch opened a new pull request #4372: Set default row_limit to 50k

mistercrunch opened a new pull request #4372: Set default row_limit to 50k URL: https://github.com/apache/incubator-superset/pull/4372 Note that users can still bump up or clear that number and effectively not limit the amount of data returned.

[GitHub] raffas commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters

raffas commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-363831915 If you use a Table View, you can make it filterable. If you click on a row,

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-363848813 I built from git, but I don't know exactly how to find the hash. I looked at my fork and the last pull from the main repo looks like

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-363870773 How could that happen? I am not able to select metrics that doesn't exist. Also I am using the default `COUNT(*)` metric.

[GitHub] mistercrunch opened a new pull request #4373: Remove dangerouslySetInnerHTML in StackTraceMessage component

mistercrunch opened a new pull request #4373: Remove dangerouslySetInnerHTML in StackTraceMessage component URL: https://github.com/apache/incubator-superset/pull/4373 Druid sometimes returns error message that are contained in "<>", as in ``. Since Superset's approach is often to

[GitHub] vylc opened a new issue #4376: Landing Page for Superset

vylc opened a new issue #4376: Landing Page for Superset URL: https://github.com/apache/incubator-superset/issues/4376 Improve usability and discovery by re-organizing landing page for when users land on Superset. With the current layout, it's hard to find what data to start exploring

[GitHub] maver1ck commented on issue #4374: Very big visualizations' thumbnails size

maver1ck commented on issue #4374: Very big visualizations' thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374#issuecomment-363934543 #4375 My idea is to create copy of images to use it in app. It's because images are also used in documentation.

[GitHub] mistercrunch closed pull request #4359: [revert] Reverting PR #4062

mistercrunch closed pull request #4359: [revert] Reverting PR #4062 URL: https://github.com/apache/incubator-superset/pull/4359 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mistercrunch closed pull request #4377: Bump pydruid to 0.4.1

mistercrunch closed pull request #4377: Bump pydruid to 0.4.1 URL: https://github.com/apache/incubator-superset/pull/4377 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] mistercrunch opened a new pull request #4377: Bump pydruid to 0.4.1

mistercrunch opened a new pull request #4377: Bump pydruid to 0.4.1 URL: https://github.com/apache/incubator-superset/pull/4377 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mistercrunch commented on issue #4377: Bump pydruid to 0.4.1

mistercrunch commented on issue #4377: Bump pydruid to 0.4.1 URL: https://github.com/apache/incubator-superset/pull/4377#issuecomment-363959814 )'( This is an automated message from the Apache Git Service. To respond to the

[GitHub] mistercrunch commented on issue #4377: Bump pydruid to 0.4.1

mistercrunch commented on issue #4377: Bump pydruid to 0.4.1 URL: https://github.com/apache/incubator-superset/pull/4377#issuecomment-363959814 `)'(` This is an automated message from the Apache Git Service. To respond to

[GitHub] hughhhh commented on issue #4372: Set default row_limit to 50k

hug commented on issue #4372: Set default row_limit to 50k URL: https://github.com/apache/incubator-superset/pull/4372#issuecomment-363926913 ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] mistercrunch closed pull request #4333: Add hour grain to SQLite

mistercrunch closed pull request #4333: Add hour grain to SQLite URL: https://github.com/apache/incubator-superset/pull/4333 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] maver1ck commented on issue #4374: Very big visualizations' thumbnails size

maver1ck commented on issue #4374: Very big visualizations' thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374#issuecomment-363934543 #4375 My idea is to create copy of images to use it in app. It's because images are also used in documentation.

[GitHub] hughhhh commented on issue #4373: Remove dangerouslySetInnerHTML in StackTraceMessage component

hug commented on issue #4373: Remove dangerouslySetInnerHTML in StackTraceMessage component URL: https://github.com/apache/incubator-superset/pull/4373#issuecomment-363928060 ? This is an automated message from the

[GitHub] hughhhh commented on issue #4341: Bump python dependencies

hug commented on issue #4341: Bump python dependencies URL: https://github.com/apache/incubator-superset/pull/4341#issuecomment-363928253 ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] mistercrunch closed pull request #4316: Fix caching related issues

mistercrunch closed pull request #4316: Fix caching related issues URL: https://github.com/apache/incubator-superset/pull/4316 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mistercrunch closed pull request #4373: Remove dangerouslySetInnerHTML in StackTraceMessage component

mistercrunch closed pull request #4373: Remove dangerouslySetInnerHTML in StackTraceMessage component URL: https://github.com/apache/incubator-superset/pull/4373 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] mistercrunch closed pull request #4341: Bump python dependencies

mistercrunch closed pull request #4341: Bump python dependencies URL: https://github.com/apache/incubator-superset/pull/4341 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mistercrunch closed pull request #4363: [line] improve "Time Shift" feature

mistercrunch closed pull request #4363: [line] improve "Time Shift" feature URL: https://github.com/apache/incubator-superset/pull/4363 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] maver1ck opened a new issue #4374: Very big visualization thumbnails size

maver1ck opened a new issue #4374: Very big visualization thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superset logs for python stacktraces and

[GitHub] hughhhh commented on issue #4363: [line] improve "Time Shift" feature

hug commented on issue #4363: [line] improve "Time Shift" feature URL: https://github.com/apache/incubator-superset/pull/4363#issuecomment-363927917 ? This is an automated message from the Apache Git Service. To respond

[GitHub] mistercrunch closed pull request #4372: Set default row_limit to 50k

mistercrunch closed pull request #4372: Set default row_limit to 50k URL: https://github.com/apache/incubator-superset/pull/4372 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mistercrunch commented on issue #4374: Very big visualizations' thumbnails size

mistercrunch commented on issue #4374: Very big visualizations' thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374#issuecomment-363934256 Would love if someone could contribute 512*512 jpg instead of 1024*1024 png

[GitHub] maver1ck commented on issue #4374: Very big visualizations' thumbnails size

maver1ck commented on issue #4374: Very big visualizations' thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374#issuecomment-363934543 Work in progress This is an automated message from the Apache

[GitHub] maver1ck opened a new pull request #4375: Smaller thumbnails - #4374

maver1ck opened a new pull request #4375: Smaller thumbnails - #4374 URL: https://github.com/apache/incubator-superset/pull/4375 Smaller thumbnails for Visualizations Drop from 11MB to 1,7MB in size This is an automated

[GitHub] mistercrunch opened a new pull request #4380: [error handling] 'Time Comparison' query returns no data

mistercrunch opened a new pull request #4380: [error handling] 'Time Comparison' query returns no data URL: https://github.com/apache/incubator-superset/pull/4380 Will show `No data` instead of `'NoneType' object has no attribute '__getitem__'`

[GitHub] mistercrunch commented on issue #4378: [Histogram] Add default to row limit

mistercrunch commented on issue #4378: [Histogram] Add default to row limit URL: https://github.com/apache/incubator-superset/issues/4378#issuecomment-364010934 fixed by https://github.com/apache/incubator-superset/pull/4372

[GitHub] mistercrunch closed issue #4378: [Histogram] Add default to row limit

mistercrunch closed issue #4378: [Histogram] Add default to row limit URL: https://github.com/apache/incubator-superset/issues/4378 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] maver1ck commented on issue #4355: Superset issue #4354 - Properly filter datasources

maver1ck commented on issue #4355: Superset issue #4354 - Properly filter datasources URL: https://github.com/apache/incubator-superset/pull/4355#issuecomment-364029476 @xrmx I think access_tests will be better. Looking into it.

[GitHub] mistercrunch commented on issue #4374: Very big visualizations' thumbnails size

mistercrunch commented on issue #4374: Very big visualizations' thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374#issuecomment-364011886 I like having the 2 different sizes. This is an automated

[GitHub] mistercrunch commented on issue #4371: Mapbox isn't working on Druid

mistercrunch commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364012069 Mind sharing your JSON? I'm guessing there's a reference that doesn't line up somehow

[GitHub] zyt312074545 commented on issue #4351: use enum.Enum to rewrite querystatus

zyt312074545 commented on issue #4351: use enum.Enum to rewrite querystatus URL: https://github.com/apache/incubator-superset/pull/4351#issuecomment-364029457 Sorry, when I see the QueryStatus is Enum-type but it inherited from Object, so I think Enum is better. You are right. But

[GitHub] mistercrunch commented on issue #4193: Init docker for local development environment.

mistercrunch commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-364010237 I'm 100% sure that `superset_config.py` shouldn't be in the main package though, it seems conflictual and potentially

[GitHub] mistercrunch commented on issue #4375: [WIP] Smaller thumbnails - #4374

mistercrunch commented on issue #4375: [WIP] Smaller thumbnails - #4374 URL: https://github.com/apache/incubator-superset/pull/4375#issuecomment-364010337 I see the WIP tag, let us know when this is ready to ship This is an

[GitHub] maver1ck commented on issue #4375: Smaller thumbnails - #4374

maver1ck commented on issue #4375: Smaller thumbnails - #4374 URL: https://github.com/apache/incubator-superset/pull/4375#issuecomment-364022475 I closed it because I created second PR. This is an automated message from the

[GitHub] mistercrunch commented on issue #4375: [WIP] Smaller thumbnails - #4374

mistercrunch commented on issue #4375: [WIP] Smaller thumbnails - #4374 URL: https://github.com/apache/incubator-superset/pull/4375#issuecomment-364006815 jpg could be good here too, but this is already better than before

[GitHub] mistercrunch commented on issue #4376: Landing Page for Superset

mistercrunch commented on issue #4376: Landing Page for Superset URL: https://github.com/apache/incubator-superset/issues/4376#issuecomment-364011771 Related: https://github.com/apache/incubator-superset/pull/4381 This is an

[GitHub] mistercrunch opened a new pull request #4381: [WiP] Phantom JS

mistercrunch opened a new pull request #4381: [WiP] Phantom JS URL: https://github.com/apache/incubator-superset/pull/4381 Did some work to get a headless browser going last april but never got to a perfect state. I'd say this is 60-80% done, needs a bit more TLC

[GitHub] masterlittle commented on issue #4381: [WiP] Phantom JS

masterlittle commented on issue #4381: [WiP] Phantom JS URL: https://github.com/apache/incubator-superset/pull/4381#issuecomment-364019511 Can this be extended to capture screenshots of dashboard and shooting a mail at some intervals?

[GitHub] maver1ck commented on issue #4374: Very big visualizations' thumbnails size

maver1ck commented on issue #4374: Very big visualizations' thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374#issuecomment-364022054 I was thinking about it. Having two sizes makes also python package 10MB bigger. And it's more difficult to maintain in

[GitHub] maver1ck closed pull request #4375: Smaller thumbnails - #4374

maver1ck closed pull request #4375: Smaller thumbnails - #4374 URL: https://github.com/apache/incubator-superset/pull/4375 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] mistercrunch commented on a change in pull request #4346: Add permission checks to save_or_overwrite_slice

mistercrunch commented on a change in pull request #4346: Add permission checks to save_or_overwrite_slice URL: https://github.com/apache/incubator-superset/pull/4346#discussion_r166836344 ## File path: superset/views/core.py ## @@ -1182,6 +1182,11 @@ def explore(self,

[GitHub] xiaohanyu commented on issue #4193: Init docker for local development environment.

xiaohanyu commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-364017144 @mistercrunch Agree with you about the `superset_config.py` things. About the second part, I'll do a later

[GitHub] maver1ck commented on issue #4323: Hive queries run at least 5 * some_number seconds

maver1ck commented on issue #4323: Hive queries run at least 5 * some_number seconds URL: https://github.com/apache/incubator-superset/issues/4323#issuecomment-364017786 Closing as PR is merged This is an automated message

[GitHub] mistercrunch commented on issue #4379: Chart stickiness - saved state

mistercrunch commented on issue #4379: Chart stickiness - saved state URL: https://github.com/apache/incubator-superset/issues/4379#issuecomment-364010800 I agree it'd be nice to save the state of the legend filters in the nvd3 charts specifically.

[GitHub] habalux commented on issue #4319: convert postgresql date_trunc() to UTC to prevent pandas error

habalux commented on issue #4319: convert postgresql date_trunc() to UTC to prevent pandas error URL: https://github.com/apache/incubator-superset/pull/4319#issuecomment-363704684 I ran some more tests of my own, and it seems that just converting to UTC will cause invalid times with the

[GitHub] xiaohanyu opened a new pull request #4368: Add ipdb to dev dependencies.

xiaohanyu opened a new pull request #4368: Add ipdb to dev dependencies. URL: https://github.com/apache/incubator-superset/pull/4368 Though flask has a builtin web debugger, ipdb some times still work better. So I think add ipdb to dev dependencies is a good option for people who

[GitHub] tony0918 opened a new issue #4369: Big blank margin for dist_bar viz

tony0918 opened a new issue #4369: Big blank margin for dist_bar viz URL: https://github.com/apache/incubator-superset/issues/4369 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included

[GitHub] SanjayJosh commented on issue #2873: Connecting Superset to Kerberized Hive with Pyhive

SanjayJosh commented on issue #2873: Connecting Superset to Kerberized Hive with Pyhive URL: https://github.com/apache/incubator-superset/issues/2873#issuecomment-363713503 @mistercrunch . When you say Hive doesn't provide a good experience with Superset, do you mean the native MapReduce

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-363745069 We're almost done. @WangXueminGit is really working quite hard on this feature and after internal code review, we'll

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-363745069 We're almost done. @WangXueminGit is really working quite hard on this feature and after internal code review, we'll

[GitHub] lexrf commented on issue #4356: Timestamp from Kylin become 1970/01/01...

lexrf commented on issue #4356: Timestamp from Kylin become 1970/01/01... URL: https://github.com/apache/incubator-superset/issues/4356#issuecomment-363760133 I debugged the code and found the problem happens in viz.py 114-122 if DTTM_ALIAS in df.columns: