[GitHub] betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx

2018-04-06 Thread GitBox
betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#discussion_r179854743 ## File path: superset/assets/javascripts/explore/stores/visTypes.js ## @@

[GitHub] betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx

2018-04-06 Thread GitBox
betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#discussion_r179855872 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@

[GitHub] betodealmeida commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration

2018-04-06 Thread GitBox
betodealmeida commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration URL: https://github.com/apache/incubator-superset/pull/4755#discussion_r179837129 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ##

[GitHub] betodealmeida commented on a change in pull request #4772: [dashboard] open in edit mode when adding a chart

2018-04-06 Thread GitBox
betodealmeida commented on a change in pull request #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#discussion_r179858801 ## File path: superset/assets/javascripts/explore/components/SaveModal.jsx ## @@

[GitHub] betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx

2018-04-06 Thread GitBox
betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#discussion_r179855498 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@

[GitHub] betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx

2018-04-06 Thread GitBox
betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#discussion_r179855277 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@

[GitHub] betodealmeida commented on a change in pull request #4765: [line] fix verbose names in time shift

2018-04-06 Thread GitBox
betodealmeida commented on a change in pull request #4765: [line] fix verbose names in time shift URL: https://github.com/apache/incubator-superset/pull/4765#discussion_r179863054 ## File path: superset/assets/spec/javascripts/visualizations/nvd3_viz_spec.jsx ## @@ -0,0

[GitHub] betodealmeida commented on a change in pull request #4765: [line] fix verbose names in time shift

2018-04-06 Thread GitBox
betodealmeida commented on a change in pull request #4765: [line] fix verbose names in time shift URL: https://github.com/apache/incubator-superset/pull/4765#discussion_r179863177 ## File path: superset/assets/visualizations/nvd3_vis.js ## @@ -83,23 +83,24 @@ function

[GitHub] codecov-io commented on issue #4773: Fix brush with annotations

2018-04-06 Thread GitBox
codecov-io commented on issue #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773#issuecomment-379135096 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=h1) Report > Merging

[GitHub] mistercrunch closed pull request #4768: [Bug fix] Resolving key conflicts in Timeseries Annotation Layer when key is a string

2018-04-06 Thread GitBox
mistercrunch closed pull request #4768: [Bug fix] Resolving key conflicts in Timeseries Annotation Layer when key is a string URL: https://github.com/apache/incubator-superset/pull/4768 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] mistercrunch closed pull request #4778: Add notes to contrib file about testing and code coverage

2018-04-06 Thread GitBox
mistercrunch closed pull request #4778: Add notes to contrib file about testing and code coverage URL: https://github.com/apache/incubator-superset/pull/4778 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] Tresdon commented on issue #4725: [WIP] Add "Published" feature to dashboards

2018-04-06 Thread GitBox
Tresdon commented on issue #4725: [WIP] Add "Published" feature to dashboards URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-379393919 Thanks for such useful and quick feedback on this, A couple thoughts and things to do yet - Ah yeah the `yarn.lock` did

[GitHub] mistercrunch closed pull request #4766: [explore] set control default for *showminmax = false

2018-04-06 Thread GitBox
mistercrunch closed pull request #4766: [explore] set control default for *showminmax = false URL: https://github.com/apache/incubator-superset/pull/4766 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch closed pull request #4773: Fix brush with annotations

2018-04-06 Thread GitBox
mistercrunch closed pull request #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mistercrunch commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio'

2018-04-06 Thread GitBox
mistercrunch commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio' URL: https://github.com/apache/incubator-superset/pull/4774#issuecomment-379408597 Oh the idea is that when using a period ratio, we're looking at a % change, so we should change the

[GitHub] mistercrunch closed pull request #4755: Pass granularity from backend to frontend as ISO duration

2018-04-06 Thread GitBox
mistercrunch closed pull request #4755: Pass granularity from backend to frontend as ISO duration URL: https://github.com/apache/incubator-superset/pull/4755 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch closed pull request #4767: Improve controls layout for Table visualization

2018-04-06 Thread GitBox
mistercrunch closed pull request #4767: Improve controls layout for Table visualization URL: https://github.com/apache/incubator-superset/pull/4767 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] vylc opened a new issue #4779: [Heatmap] Time granularity not applied

2018-04-06 Thread GitBox
vylc opened a new issue #4779: [Heatmap] Time granularity not applied URL: https://github.com/apache/incubator-superset/issues/4779 Druid Datasource Timestamp chosen as y-axis (though also doesn't work when chosen as x-axis) Dimension chosen as x-axis Time granularity rolled up to

[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart

2018-04-06 Thread GitBox
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart

2018-04-06 Thread GitBox
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging

[GitHub] ttannis opened a new pull request #4778: Add notes to contrib file about testing and code coverage

2018-04-06 Thread GitBox
ttannis opened a new pull request #4778: Add notes to contrib file about testing and code coverage URL: https://github.com/apache/incubator-superset/pull/4778 @betodealmeida asked that we add notes about how to check code coverage since we'd want to move towards that getting better. Also

[GitHub] codecov-io commented on issue #4778: Add notes to contrib file about testing and code coverage

2018-04-06 Thread GitBox
codecov-io commented on issue #4778: Add notes to contrib file about testing and code coverage URL: https://github.com/apache/incubator-superset/pull/4778#issuecomment-379397208 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4778?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4777: [doc] module header for controls.jsx and visTypes.jsx

2018-04-06 Thread GitBox
codecov-io commented on issue #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#issuecomment-379300038 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=h1) Report > Merging

[GitHub] emirot opened a new pull request #4780: [i18n] Add French translation

2018-04-06 Thread GitBox
emirot opened a new pull request #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780 I would like to add some french translations but I don't know what to refer to because the navbar_menu is auto generated.

[GitHub] codecov-io commented on issue #4780: [i18n] Add French translation

2018-04-06 Thread GitBox
codecov-io commented on issue #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780#issuecomment-379434331 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4780: [i18n] Add French translation

2018-04-06 Thread GitBox
codecov-io commented on issue #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780#issuecomment-379434331 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4780: [i18n] Add French translation

2018-04-06 Thread GitBox
codecov-io commented on issue #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780#issuecomment-379434331 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=h1) Report > Merging

[GitHub] mistercrunch opened a new pull request #4774: [explore] forcing .1% number format when using 'Period Ratio'

2018-04-06 Thread GitBox
mistercrunch opened a new pull request #4774: [explore] forcing .1% number format when using 'Period Ratio' URL: https://github.com/apache/incubator-superset/pull/4774 https://user-images.githubusercontent.com/487433/38406333-45bd2d56-3929-11e8-9802-fe9c57dcc613.png;>

[GitHub] codecov-io commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio'

2018-04-06 Thread GitBox
codecov-io commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio' URL: https://github.com/apache/incubator-superset/pull/4774#issuecomment-379164432 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio'

2018-04-06 Thread GitBox
codecov-io commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio' URL: https://github.com/apache/incubator-superset/pull/4774#issuecomment-379164432 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=h1) Report > Merging

[GitHub] SpyderRivera commented on issue #4747: [WiP] Download Dashboards as PDF

2018-04-06 Thread GitBox
SpyderRivera commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-379235250 @abowden-spotx Can you add some detail around the way you are approaching this?

[GitHub] jhettler opened a new issue #4775: Users should't see databases with no privileges in Upload CSV dialog

2018-04-06 Thread GitBox
jhettler opened a new issue #4775: Users should't see databases with no privileges in Upload CSV dialog URL: https://github.com/apache/incubator-superset/issues/4775 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs

[GitHub] aleksi75 opened a new issue #4776: [Druid] Superset not working with Druid when 'Druid Basic Security' is activated

2018-04-06 Thread GitBox
aleksi75 opened a new issue #4776: [Druid] Superset not working with Druid when 'Druid Basic Security' is activated URL: https://github.com/apache/incubator-superset/issues/4776 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the

[GitHub] syzuhdi commented on issue #4770: Cannot display Time Series Line Chart

2018-04-06 Thread GitBox
syzuhdi commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379170928 Thank you @jhettler. It works for us. This is an automated message

[GitHub] mistercrunch opened a new pull request #4777: [doc] module header for controls.jsx and visTypes.jsx

2018-04-06 Thread GitBox
mistercrunch opened a new pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777 This is an automated message from the Apache Git Service. To

[GitHub] guillaumewibaux commented on issue #2731: Give users the rights to change their password

2018-04-06 Thread GitBox
guillaumewibaux commented on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-379314959 I am not sure but I am afraid there is a mismatch between ResetMyPasswordView and ResetPasswordView. With the

[GitHub] mistercrunch commented on a change in pull request #4747: [WiP] Download Dashboards as PDF

2018-04-06 Thread GitBox
mistercrunch commented on a change in pull request #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#discussion_r179802837 ## File path: superset/assets/javascripts/dashboard/components/Header.jsx ## @@ -68,6 +69,19 @@

[GitHub] codecov-io commented on issue #4771: [druid] fix 'Unorderable types' when col has nuls

2018-04-06 Thread GitBox
codecov-io commented on issue #4771: [druid] fix 'Unorderable types' when col has nuls URL: https://github.com/apache/incubator-superset/pull/4771#issuecomment-379302137 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4771?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty

2018-04-06 Thread GitBox
mistercrunch commented on issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty URL: https://github.com/apache/incubator-superset/issues/4635#issuecomment-379309387 `0.24.0` is out, closing

[GitHub] mistercrunch commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration

2018-04-06 Thread GitBox
mistercrunch commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration URL: https://github.com/apache/incubator-superset/pull/4755#discussion_r179802253 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ##

[GitHub] mistercrunch commented on issue #4747: [WiP] Download Dashboards as PDF

2018-04-06 Thread GitBox
mistercrunch commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-379299458 The absolute easiest here would be to 1) hide the menu bar, this can be done with the `=true` URL param, but perhaps could be done

[GitHub] mistercrunch commented on issue #4747: [WiP] Download Dashboards as PDF

2018-04-06 Thread GitBox
mistercrunch commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-379299458 The absolute easiest here would be to 1) hide the menu bar, this can be done with the `=true` URL param, but perhaps could be done

[GitHub] codecov-io commented on issue #4777: [doc] module header for controls.jsx and visTypes.jsx

2018-04-06 Thread GitBox
codecov-io commented on issue #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#issuecomment-379300038 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4770: Cannot display Time Series Line Chart

2018-04-06 Thread GitBox
mistercrunch commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379300129 This may help these issues: https://github.com/apache/incubator-superset/pull/4724

[GitHub] mistercrunch closed issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty

2018-04-06 Thread GitBox
mistercrunch closed issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty URL: https://github.com/apache/incubator-superset/issues/4635 This is an automated message from the Apache

[GitHub] lprashant-94 commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

2018-04-06 Thread GitBox
lprashant-94 commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-379319482 @mistercrunch @vylc, I have tested command + C behaviour. If we double click on column and copy then

[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

2018-04-06 Thread GitBox
codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=h1) Report > Merging