[GitHub] xrmx commented on issue #4780: [i18n] Add French translation

2018-04-11 Thread GitBox
xrmx commented on issue #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780#issuecomment-380360213 @emirot merci! :) This is an automated message from the Apache Git Service. To

[GitHub] myarnav commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly

2018-04-11 Thread GitBox
myarnav commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly URL: https://github.com/apache/incubator-superset/issues/4612#issuecomment-380419500 Hi, I have setup async in SQL Lab, and setup celery with redis. My superset_config.py file is on

[GitHub] myarnav commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly

2018-04-11 Thread GitBox
myarnav commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly URL: https://github.com/apache/incubator-superset/issues/4612#issuecomment-380419500 Hi, I have setup async in SQL Lab, and setup celery with redis. My superset_config.py file is on

[GitHub] myarnav commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly

2018-04-11 Thread GitBox
myarnav commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly URL: https://github.com/apache/incubator-superset/issues/4612#issuecomment-380419500 Hi, I have setup async in SQL Lab, and setup celery with redis. My superset_config.py file is on

[GitHub] deepak-goel commented on issue #4785: Not able to get the debug logs or python stacktrace on errors even after LOG_LEVEL is set to 'DEBUG'

2018-04-11 Thread GitBox
deepak-goel commented on issue #4785: Not able to get the debug logs or python stacktrace on errors even after LOG_LEVEL is set to 'DEBUG' URL: https://github.com/apache/incubator-superset/issues/4785#issuecomment-380430067 I got this working. I added the following 3 parameters

[GitHub] deepak-goel closed issue #4785: Not able to get the debug logs or python stacktrace on errors even after LOG_LEVEL is set to 'DEBUG'

2018-04-11 Thread GitBox
deepak-goel closed issue #4785: Not able to get the debug logs or python stacktrace on errors even after LOG_LEVEL is set to 'DEBUG' URL: https://github.com/apache/incubator-superset/issues/4785 This is an automated message

[GitHub] SpyderRivera commented on issue #4525: Superset issue #4512: multiple metrics, group by, opacity, legends for histogram

2018-04-11 Thread GitBox
SpyderRivera commented on issue #4525: Superset issue #4512: multiple metrics, group by, opacity, legends for histogram URL: https://github.com/apache/incubator-superset/pull/4525#issuecomment-380460949

[GitHub] codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values.

2018-04-11 Thread GitBox
codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values. URL: https://github.com/apache/incubator-superset/pull/4712#issuecomment-380476608 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr=h1)

[GitHub] john-bodley commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly

2018-04-11 Thread GitBox
john-bodley commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly URL: https://github.com/apache/incubator-superset/issues/4612#issuecomment-380522122 @myarnav I few things to check: 1. Is your Redis service running? 2. It seems that you

[GitHub] codecov-io commented on issue #4806: [tests] cleaning up test configuration

2018-04-11 Thread GitBox
codecov-io commented on issue #4806: [tests] cleaning up test configuration URL: https://github.com/apache/incubator-superset/pull/4806#issuecomment-380523853 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4806?src=pr=h1) Report > Merging

[GitHub] john-bodley opened a new pull request #4806: [tests] cleaning up test configuration

2018-04-11 Thread GitBox
john-bodley opened a new pull request #4806: [tests] cleaning up test configuration URL: https://github.com/apache/incubator-superset/pull/4806 This PR deletes the obsolete `run_specfic_test.sh` script which is now handled via `tox`. Additionally the need for setting the `SUPERSET_CONFIG`

[GitHub] jeffreythewang commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
jeffreythewang commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380523149 @john-bodley Yes that is the current logic. This change mainly addresses the case where a Dashboard is empty, as the user

[GitHub] JeppeSigaard commented on issue #4712: Added localecompare array sort to datahandler, fetchFilterValues

2018-04-11 Thread GitBox
JeppeSigaard commented on issue #4712: Added localecompare array sort to datahandler, fetchFilterValues URL: https://github.com/apache/incubator-superset/pull/4712#issuecomment-380472916 Well, in terms of database in use, I just popped open the dev setup. Non-alphabetical values can be

[GitHub] codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values.

2018-04-11 Thread GitBox
codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values. URL: https://github.com/apache/incubator-superset/pull/4712#issuecomment-380476608 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr=h1)

[GitHub] codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values.

2018-04-11 Thread GitBox
codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values. URL: https://github.com/apache/incubator-superset/pull/4712#issuecomment-380476608 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr=h1)

[GitHub] JeppeSigaard commented on issue #4712: Added localecompare array sort to datahandler, fetchFilterValues

2018-04-11 Thread GitBox
JeppeSigaard commented on issue #4712: Added localecompare array sort to datahandler, fetchFilterValues URL: https://github.com/apache/incubator-superset/pull/4712#issuecomment-380472916 Well, in terms of database in use, I just popped open the dev setup. Non-alphabetical values can be

[GitHub] john-bodley commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
john-bodley commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380519069 @jeffreythewang isn't the current logic that a user is able to see the dashboard if the have access to _at least_ one of the

Curl Based REST API For Superset Slice & Dashboard Creation

2018-04-11 Thread ashutosh khira
Hi, Please provide Curl Based REST API document for superset’s slice & dashboard creation. Thanks Ashutosh Khira

[GitHub] codecov-io commented on issue #4806: [tests] cleaning up test configuration

2018-04-11 Thread GitBox
codecov-io commented on issue #4806: [tests] cleaning up test configuration URL: https://github.com/apache/incubator-superset/pull/4806#issuecomment-380523853 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4806?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
john-bodley commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380540209 Thanks @jeffreythewang This is an automated message from the

[GitHub] mistercrunch opened a new pull request #4807: Make the bottom margin a bit taller

2018-04-11 Thread GitBox
mistercrunch opened a new pull request #4807: Make the bottom margin a bit taller URL: https://github.com/apache/incubator-superset/pull/4807 https://user-images.githubusercontent.com/487433/38634108-768b04ca-3d76-11e8-8bd2-c6d3c24a8ceb.png;>

[GitHub] jeffreythewang commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
jeffreythewang commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380537061 @john-bodley I think what I meant by that was, if there is a dashboard where all of the charts on that dashboard are

[GitHub] jeffreythewang commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
jeffreythewang commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380537061 @john-bodley I think what I meant by that was, if there is a dashboard where all of the charts on that dashboard are

[GitHub] codecov-io commented on issue #4651: [explore] proper filtering of NULLs and ''

2018-04-11 Thread GitBox
codecov-io commented on issue #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4651: [explore] proper filtering of NULLs and ''

2018-04-11 Thread GitBox
codecov-io commented on issue #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''

2018-04-11 Thread GitBox
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging

[GitHub] jeffreythewang commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
jeffreythewang commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380537061 Ah I see. Yeah that comment was written before https://github.com/apache/incubator-superset/pull/4405 was merged. I've

[GitHub] jeffreythewang commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
jeffreythewang commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380537061 @john-bodley Ah I see. Yeah that comment was written before I was aware of

[GitHub] jeffreythewang commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
jeffreythewang commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380537061 @john-bodley Ah I see. Yeah that comment was written before https://github.com/apache/incubator-superset/pull/4405 was

[GitHub] john-bodley commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
john-bodley commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380530013 @jeffreythewang I agree with your logic regarding empty dashboards which this PR resolves, but I think your original comment

[GitHub] timifasubaa commented on issue #4804: [upload csv to hive] fix call to unicodereader.next()

2018-04-11 Thread GitBox
timifasubaa commented on issue #4804: [upload csv to hive] fix call to unicodereader.next() URL: https://github.com/apache/incubator-superset/pull/4804#issuecomment-380561299 @john-bodley yes. Thanks for making it clearer. I updated the PR description I tested on python2 and 3 and it

[GitHub] codecov-io commented on issue #4806: [tests] cleaning up test configuration

2018-04-11 Thread GitBox
codecov-io commented on issue #4806: [tests] cleaning up test configuration URL: https://github.com/apache/incubator-superset/pull/4806#issuecomment-380523853 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4806?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4520: Allow users to view dashboards they own

2018-04-11 Thread GitBox
john-bodley commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-380540555 Note this filter is also used when you try to add a slice to an existing dashboard and thus if you create an empty dashboard

[GitHub] timifasubaa commented on issue #4659: Adding tests for the time table viz

2018-04-11 Thread GitBox
timifasubaa commented on issue #4659: Adding tests for the time table viz URL: https://github.com/apache/incubator-superset/pull/4659#issuecomment-380561863 @mistercrunch @john-bodley Why haven't we merged this? This is an

[GitHub] john-bodley commented on issue #4804: [upload csv to hive] fix call to unicodereader.next()

2018-04-11 Thread GitBox
john-bodley commented on issue #4804: [upload csv to hive] fix call to unicodereader.next() URL: https://github.com/apache/incubator-superset/pull/4804#issuecomment-380565990 LGTM This is an automated message from the

[GitHub] john-bodley commented on issue #4804: [upload csv to hive] fix call to unicodereader.next()

2018-04-11 Thread GitBox
john-bodley commented on issue #4804: [upload csv to hive] fix call to unicodereader.next() URL: https://github.com/apache/incubator-superset/pull/4804#issuecomment-380565990 LGTM This is an automated message from the

[GitHub] codecov-io commented on issue #4807: Make the bottom margin a bit taller

2018-04-11 Thread GitBox
codecov-io commented on issue #4807: Make the bottom margin a bit taller URL: https://github.com/apache/incubator-superset/pull/4807#issuecomment-380544999 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4807?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4807: Make the bottom margin a bit taller

2018-04-11 Thread GitBox
codecov-io commented on issue #4807: Make the bottom margin a bit taller URL: https://github.com/apache/incubator-superset/pull/4807#issuecomment-380544999 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4807?src=pr=h1) Report > Merging

[GitHub] timifasubaa commented on issue #4804: [upload csv to hive] fix call to unicodereader.next()

2018-04-11 Thread GitBox
timifasubaa commented on issue #4804: [upload csv to hive] fix call to unicodereader.next() URL: https://github.com/apache/incubator-superset/pull/4804#issuecomment-380561299 @john-bodley yes. Thanks for clarifying. I updated the PR description. I tested on python2 and 3 and it works

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here is my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here is my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here are my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] hughhhh closed pull request #4809: Filter recently viewed to just have explore and dashboard types

2018-04-11 Thread GitBox
hug closed pull request #4809: Filter recently viewed to just have explore and dashboard types URL: https://github.com/apache/incubator-superset/pull/4809 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch closed pull request #4803: [explore] set working default for MetricsControl

2018-04-11 Thread GitBox
mistercrunch closed pull request #4803: [explore] set working default for MetricsControl URL: https://github.com/apache/incubator-superset/pull/4803 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch closed pull request #4801: [bugfix] dedup groupby columns in Deck visualizations

2018-04-11 Thread GitBox
mistercrunch closed pull request #4801: [bugfix] dedup groupby columns in Deck visualizations URL: https://github.com/apache/incubator-superset/pull/4801 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch closed pull request #4807: Make the bottom margin a bit taller

2018-04-11 Thread GitBox
mistercrunch closed pull request #4807: Make the bottom margin a bit taller URL: https://github.com/apache/incubator-superset/pull/4807 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mistercrunch commented on issue #4793: [line] do not show 0 or nulls in rich tooltip

2018-04-11 Thread GitBox
mistercrunch commented on issue #4793: [line] do not show 0 or nulls in rich tooltip URL: https://github.com/apache/incubator-superset/pull/4793#issuecomment-380612770 @vylc `Show Zeroes in Tooltip` boolean? This is an

[GitHub] williaster commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380619142 @graceguo-supercat 1) the code history etc is a valid concern. I think we should still delete v1, but move files with

[GitHub] williaster commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380619142 @graceguo-supercat 1) the code history etc is a valid concern. I think we should still delete v1, but move files with

[GitHub] codecov-io commented on issue #4793: [line] do not show 0 or nulls in rich tooltip

2018-04-11 Thread GitBox
codecov-io commented on issue #4793: [line] do not show 0 or nulls in rich tooltip URL: https://github.com/apache/incubator-superset/pull/4793#issuecomment-379988834 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4793?src=pr=h1) Report > Merging

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here is my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] hughhhh commented on issue #4809: Filter recently viewed to just have explore and dashboard types

2018-04-11 Thread GitBox
hug commented on issue #4809: Filter recently viewed to just have explore and dashboard types URL: https://github.com/apache/incubator-superset/pull/4809#issuecomment-380609167 Dupe #4808 This is an automated message

[GitHub] mistercrunch commented on issue #4801: [bugfix] dedup groupby columns in Deck visualizations

2018-04-11 Thread GitBox
mistercrunch commented on issue #4801: [bugfix] dedup groupby columns in Deck visualizations URL: https://github.com/apache/incubator-superset/pull/4801#issuecomment-380613068 Didn't want to risk it, the set and list api are not the exact same, not sure if we handle the conversion on

[GitHub] mistercrunch commented on issue #4807: Make the bottom margin a bit taller

2018-04-11 Thread GitBox
mistercrunch commented on issue #4807: Make the bottom margin a bit taller URL: https://github.com/apache/incubator-superset/pull/4807#issuecomment-380613354 Yeah I had validated the changes mostly in the explore view which has it's own padding, so I missed how close to the edge is was.

[GitHub] GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180903978 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] betodealmeida commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test

2018-04-11 Thread GitBox
betodealmeida commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test URL: https://github.com/apache/incubator-superset/pull/4798#discussion_r180908278 ## File path: tests/utils.py ## @@ -0,0 +1,14 @@ +# -*- coding: utf-8 -*- +from __future__

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here are my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] williaster commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380619142 @graceguo-supercat 1) the code history etc is a valid concern. I think we should still delete v1, but move files with

[GitHub] mistercrunch closed pull request #4804: [upload csv to hive] fix call to unicodereader.next()

2018-04-11 Thread GitBox
mistercrunch closed pull request #4804: [upload csv to hive] fix call to unicodereader.next() URL: https://github.com/apache/incubator-superset/pull/4804 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180884402 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap

2018-04-11 Thread GitBox
betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180903916 ## File path: superset/assets/javascripts/modules/colors.js ## @@ -122,6 +122,42 @@ export const

[GitHub] mistercrunch closed pull request #4133: BugFix(#3658)

2018-04-11 Thread GitBox
mistercrunch closed pull request #4133: BugFix(#3658) URL: https://github.com/apache/incubator-superset/pull/4133 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] mistercrunch commented on issue #4659: Adding tests for the time table viz

2018-04-11 Thread GitBox
mistercrunch commented on issue #4659: Adding tests for the time table viz URL: https://github.com/apache/incubator-superset/pull/4659#issuecomment-380584663 I think for committers it's preferable for them to merge their own PRs as they might know things others don't or may want to merge

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879257 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,36 +8,17 @@ import {

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879319 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,36 +8,17 @@ import {

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180872812 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -87,12

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876462 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874993 ## File path: superset/assets/javascripts/dashboard/components/GridLayout.jsx ## @@ -1,33

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881204 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] mistercrunch commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly

2018-04-11 Thread GitBox
mistercrunch commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly URL: https://github.com/apache/incubator-superset/issues/4612#issuecomment-380587655 Also make sure the port is open, I usually check using the `telnet {host} {port}` command

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180869980 ## File path: superset/assets/javascripts/dashboard/actions/allSlices.js ## @@ -0,0 +1,66 @@

[GitHub] michellethomas commented on issue #4659: Adding tests for the time table viz

2018-04-11 Thread GitBox
michellethomas commented on issue #4659: Adding tests for the time table viz URL: https://github.com/apache/incubator-superset/pull/4659#issuecomment-380594393 I don't have access, I'm not a committer yet. This is an

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180897757 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180897336 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180898894 ## File path: superset/assets/javascripts/explore/components/AdhocMetricOption.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180899633 ## File path: superset/assets/spec/javascripts/explore/AdhocMetric_spec.js ## @@

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180899096 ## File path: superset/assets/javascripts/explore/components/AdhocMetricOption.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180896732 ## File path: superset/assets/javascripts/explore/AdhocMetric.js ## @@ -23,10

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180898341 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] hughhhh opened a new pull request #4808: [Welcome] Filter recently viewed to just have explore and dashboard types

2018-04-11 Thread GitBox
hug opened a new pull request #4808: [Welcome] Filter recently viewed to just have explore and dashboard types URL: https://github.com/apache/incubator-superset/pull/4808 Filter recently viewed to only show recent explore and dashboard actions

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889255 ## File path: superset/assets/javascripts/dashboard/v2/reducers/index.js ## @@ -1,17 +1,10

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876633 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883909 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180880502 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876866 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879991 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180886368 ## File path: superset/assets/javascripts/dashboard/v2/components/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180871121 ## File path: superset/assets/javascripts/chart/chartAction.js ## @@ -111,6 +111,17 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883434 ## File path: superset/assets/javascripts/dashboard/reducers/datasources.js ## @@ -0,0 +1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874259 ## File path: superset/assets/javascripts/dashboard/components/DashboardContainer.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877222 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180878276 ## File path: superset/assets/javascripts/dashboard/components/SliceHeader.jsx ## @@ -1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180875972 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -1,43

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879055 ## File path: superset/assets/javascripts/dashboard/components/SliceHeaderControls.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r18096 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardHeader.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180888627 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardGrid.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874614 ## File path: superset/assets/javascripts/dashboard/components/GridCell.jsx ## @@ -4,8 +4,8

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180869813 ## File path: superset/assets/javascripts/dashboard/actions/allSlices.js ## @@ -0,0 +1,66 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881331 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-11 Thread GitBox
williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877358 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -1,43

  1   2   >