[GitHub] GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on deck_gl charts

2018-04-04 Thread GitBox
GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on 
deck_gl charts
URL: 
https://github.com/apache/incubator-superset/pull/4610#issuecomment-378688089
 
 
   closing in favor of: https://github.com/apache/incubator-superset/pull/4729


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on deck_gl charts

2018-03-21 Thread GitBox
GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on 
deck_gl charts
URL: 
https://github.com/apache/incubator-superset/pull/4610#issuecomment-375054606
 
 
   @mistercrunch @betodealmeida bump on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on deck_gl charts

2018-03-15 Thread GitBox
GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on 
deck_gl charts
URL: 
https://github.com/apache/incubator-superset/pull/4610#issuecomment-373448059
 
 
   @mistercrunch @betodealmeida can we merge this PR for now and then come up 
with a more long term solution when you have time to address it? Would like to 
unblock users :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on deck_gl charts

2018-03-14 Thread GitBox
GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on 
deck_gl charts
URL: 
https://github.com/apache/incubator-superset/pull/4610#issuecomment-373112547
 
 
   @mistercrunch yep- not sure a better way to leverage the overlay here, this 
is the only instance of a control I've seen that rerenders but also has 
`renderTrigger: false` property.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on deck_gl charts

2018-03-13 Thread GitBox
GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on 
deck_gl charts
URL: 
https://github.com/apache/incubator-superset/pull/4610#issuecomment-372874331
 
 
   That was part of the confusion. We should still merge this PR, or the 
overlay will appear incorrectly when deck.gl charts are scrolled.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services