Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-363429089
Not sure about that. Make an issue if there isn't one already.
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-362650097
What version of superset are you using? I think this is in version 0.21.0
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-348645186
Should we replace any elements in `qry['dimensions']` that are dimension
specs with `dim_spec['dimension']`
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-348645186
Should we replace any elements in `qry['dimensions']` that are dimension
specs with `dim_spec['dimension']`
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-348643185
@fabianmenges RFC on this solution
For two-phase queries, would it be better to remove extraction
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-348637886
@ghulands
Okay I think I figured it out. Extraction functions that change the name of
dimension
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-348580355
Could you post logs from running these queries? (And it's still just doing 1
phase right?)
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-348574193
@ghulands Thanks for letting me know. I removed a condition thinking Druid
handles single `"dimension"` specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't
handle dim specs
URL:
https://github.com/apache/incubator-superset/pull/3974#issuecomment-348574193
@ghulands Thanks for letting me know. I removed a condition thinking Druid
handles single `"dimension"` specs
