[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-363429089 Not sure about that. Make an issue if there isn't one already. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-362650097 What version of superset are you using? I think this is in version 0.21.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-348645186 Should we replace any elements in `qry['dimensions']` that are dimension specs with `dim_spec['dimension']` (on which they operate) for pre-queries? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-348645186 Should we replace any elements in `qry['dimensions']` that are dimension specs with `dim_spec['dimension']` (on which they operate) for pre-queries? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-348643185 @fabianmenges RFC on this solution For two-phase queries, would it be better to remove extraction functions from pre-queries (and just use the dimension name) and add them back for the final query? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-348637886 @ghulands Okay I think I figured it out. Extraction functions that change the name of dimension values (in your case, mapping from a code to a name) cause issues with the two-phase query because it builds additional filters from output values (which are different from the original values). `_add_filters_from_pre_query` will ignore extraction functions. Give it another go. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-348580355 Could you post logs from running these queries? (And it's still just doing 1 phase right?) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-348574193 @ghulands Thanks for letting me know. I removed a condition thinking Druid handles single `"dimension"` specs but I think I was right before to check if a single dimension is a spec. Checkout the change and let me know if it's working. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-348574193 @ghulands Thanks for letting me know. I removed a condition thinking Druid handles single `"dimension"` specs but I think I was right before. Checkout the change and let me know if it's working. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
