[GitHub] codecov-io commented on issue #4551: [sql lab] option to disable cross schema search
codecov-io commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-371030577 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=h1) Report > Merging [#4551](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `88.88%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4551 +/- ## == - Coverage 71.17% 71.16% -0.02% == Files 187 187 Lines 1480914824 +15 Branches 1085 1086 +1 == + Hits1054010549 +9 - Misses 4266 4272 +6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=tree) | Coverage ? | | |---|---|---| | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `74.46% (?)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.2% (?)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.7% <100%> (-0.62%)` | :arrow_down: | | [...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `92.45% <83.33%> (-0.55%)` | :arrow_down: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `74.21% <0%> (-0.13%)` | :arrow_down: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.18% <0%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=footer). Last update [c85eea3...e78d788](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4551: [sql lab] option to disable cross schema search
codecov-io commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-371030577 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=h1) Report > Merging [#4551](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `88.88%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4551 +/- ## == - Coverage 71.17% 71.16% -0.02% == Files 187 187 Lines 1480914824 +15 Branches 1085 1086 +1 == + Hits1054010549 +9 - Misses 4266 4272 +6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=tree) | Coverage ? | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.2% (?)` | :arrow_up: | | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `74.46% (?)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.7% <100%> (-0.62%)` | :arrow_down: | | [...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `92.45% <83.33%> (-0.55%)` | :arrow_down: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `74.21% <0%> (-0.13%)` | :arrow_down: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.18% <0%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=footer). Last update [c85eea3...e78d788](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4551: [sql lab] option to disable cross schema search
codecov-io commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-371030577 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=h1) Report > Merging [#4551](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `88.88%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4551 +/- ## == - Coverage 71.17% 71.16% -0.02% == Files 187 187 Lines 1480914820 +11 Branches 1085 1086 +1 == + Hits1054010546 +6 - Misses 4266 4271 +5 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=tree) | Coverage ? | | |---|---|---| | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `74.46% (?)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.2% (?)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.7% <100%> (-0.62%)` | :arrow_down: | | [...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `92.45% <83.33%> (-0.55%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=footer). Last update [c85eea3...a57dd87](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4551: [sql lab] option to disable cross schema search
codecov-io commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-371030577 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=h1) Report > Merging [#4551](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d817b8ddbb3a8a1bd706f47ecd0934781aea100f?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `54.54%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4551 +/- ## == - Coverage71.2% 71.18% -0.02% == Files 187 187 Lines 1478214793 +11 Branches 1083 1084 +1 == + Hits1052510531 +6 - Misses 4254 4259 +5 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=tree) | Coverage ? | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.18% (?)` | :arrow_up: | | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `74.46% (?)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.81% <20%> (-0.62%)` | :arrow_down: | | [...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `92.45% <83.33%> (-0.55%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=footer). Last update [d817b8d...ca38933](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
