[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `86.84%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == + Coverage71.2% 71.24% +0.04% == Files 187 190 +3 Lines 1478514875 +90 Branches 1083 1099 +16 == + Hits1052710598 +71 - Misses 4255 4274 +19 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (ø)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <0%> (-0.58%)` | :arrow_down: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `100% <100%> (ø)` | | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [...ipts/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | `86.95% <0%> (-0.93%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.7% <0%> (-0.62%)` | :arrow_down: | | [...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `92.45% <0%> (-0.55%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...3665d4c](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `86.84%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == + Coverage71.2% 71.24% +0.04% == Files 187 190 +3 Lines 1478514875 +90 Branches 1083 1099 +16 == + Hits1052710598 +71 - Misses 4255 4274 +19 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (ø)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <0%> (-0.58%)` | :arrow_down: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `100% <100%> (ø)` | | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [...ipts/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | `86.95% <0%> (-0.93%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.7% <0%> (-0.62%)` | :arrow_down: | | [...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `92.45% <0%> (-0.55%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...3665d4c](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `73.91%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == + Coverage71.2% 71.22% +0.02% == Files 187 188 +1 Lines 1478514841 +56 Branches 1083 1096 +13 == + Hits1052710570 +43 - Misses 4255 4268 +13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `100% <100%> (?)` | | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <0%> (?)` | :arrow_up: | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...9e46f4c](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `73.91%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == + Coverage71.2% 71.22% +0.02% == Files 187 188 +1 Lines 1478514841 +56 Branches 1083 1096 +13 == + Hits1052710570 +43 - Misses 4255 4268 +13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `100% <100%> (?)` | | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | :arrow_up: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <0%> (?)` | :arrow_up: | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...9e46f4c](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `63.04%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.18% -0.02% == Files 187 188 +1 Lines 1478514841 +56 Branches 1083 1096 +13 == + Hits1052710565 +38 - Misses 4255 4272 +17 - Partials34 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `77.27% <77.27%> (?)` | | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <0%> (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...6d20431](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `63.04%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.18% -0.02% == Files 187 188 +1 Lines 1478514841 +56 Branches 1083 1096 +13 == + Hits1052710565 +38 - Misses 4255 4272 +17 - Partials34 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `77.27% <77.27%> (?)` | | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <0%> (?)` | :arrow_up: | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...6d20431](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `58.69%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.17% -0.03% == Files 187 188 +1 Lines 1478514841 +56 Branches 1083 1096 +13 == + Hits1052710563 +36 - Misses 4255 4274 +19 - Partials34 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `90.47% <75%> (-9.53%)` | :arrow_down: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `77.27% <77.27%> (?)` | | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | :arrow_up: | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...4c3c5b8](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `32.6%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.12% -0.08% == Files 187 188 +1 Lines 1478514817 +32 Branches 1083 1094 +11 == + Hits1052710538 +11 - Misses 4255 4276 +21 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `22.72% <22.72%> (?)` | | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `90.47% <75%> (-9.53%)` | :arrow_down: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...2227d61](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `32.6%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.12% -0.08% == Files 187 188 +1 Lines 1478514817 +32 Branches 1083 1094 +11 == + Hits1052710538 +11 - Misses 4255 4276 +21 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `22.72% <22.72%> (?)` | | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `90.47% <75%> (-9.53%)` | :arrow_down: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...2227d61](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/369f652bfc4aef377de33eda2c5559e6f0c5c442?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `32.6%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.12% -0.08% == Files 187 188 +1 Lines 1478514817 +32 Branches 1083 1094 +11 == + Hits1052710538 +11 - Misses 4255 4276 +21 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `22.72% <22.72%> (?)` | | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `90.47% <75%> (-9.53%)` | :arrow_down: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.15% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [369f652...2b9b20f](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/369f652bfc4aef377de33eda2c5559e6f0c5c442?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `32.6%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.12% -0.08% == Files 187 188 +1 Lines 1478514817 +32 Branches 1083 1094 +11 == + Hits1052710538 +11 - Misses 4255 4276 +21 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `22.72% <22.72%> (?)` | | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `90.47% <75%> (-9.53%)` | :arrow_down: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.15% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [369f652...2b9b20f](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/369f652bfc4aef377de33eda2c5559e6f0c5c442?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `32.6%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.12% -0.08% == Files 187 188 +1 Lines 1478514817 +32 Branches 1083 1094 +11 == + Hits1052710538 +11 - Misses 4255 4276 +21 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `22.72% <22.72%> (?)` | | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `90.47% <75%> (-9.53%)` | :arrow_down: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.15% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [369f652...2b9b20f](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/369f652bfc4aef377de33eda2c5559e6f0c5c442?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `29.26%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.12% -0.08% == Files 187 188 +1 Lines 1478514812 +27 Branches 1083 1091 +8 == + Hits1052710535 +8 - Misses 4255 4274 +19 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `22.72% <22.72%> (?)` | | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [369f652...ee5f0df](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/369f652bfc4aef377de33eda2c5559e6f0c5c442?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `29.26%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.12% -0.08% == Files 187 188 +1 Lines 1478514812 +27 Branches 1083 1091 +8 == + Hits1052710535 +8 - Misses 4255 4274 +19 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `22.72% <22.72%> (?)` | | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [369f652...ee5f0df](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
