[GitHub] codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID is defined

2018-03-12 Thread GitBox
codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID 
is defined
URL: 
https://github.com/apache/incubator-superset/pull/4573#issuecomment-371409484
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=h1)
 Report
   > Merging 
[#4573](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/2bc089ef8dcec5d98a43cb2ec80aacf1cdc706cf?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4573/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4573  +/-   ##
   ==
   + Coverage   71.18%   71.18%   +<.01% 
   ==
 Files 189  189  
 Lines   1484514846   +1 
 Branches 1086 1086  
   ==
   + Hits1056710568   +1 
 Misses   4275 4275  
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4573/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.46%  (+0.01%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=footer).
 Last update 
[2bc089e...26257d9](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID is defined

2018-03-12 Thread GitBox
codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID 
is defined
URL: 
https://github.com/apache/incubator-superset/pull/4573#issuecomment-371409484
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=h1)
 Report
   > Merging 
[#4573](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/2bc089ef8dcec5d98a43cb2ec80aacf1cdc706cf?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4573/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4573  +/-   ##
   ==
   + Coverage   71.18%   71.18%   +<.01% 
   ==
 Files 189  189  
 Lines   1484514846   +1 
 Branches 1086 1086  
   ==
   + Hits1056710568   +1 
 Misses   4275 4275  
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4573/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.46%  (+0.01%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=footer).
 Last update 
[2bc089e...26257d9](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID is defined

2018-03-07 Thread GitBox
codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID 
is defined
URL: 
https://github.com/apache/incubator-superset/pull/4573#issuecomment-371409484
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=h1)
 Report
   > Merging 
[#4573](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9ad50c9d556a2fd333c1b9933140b46c91b42c69?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4573/graphs/tree.svg?src=pr&token=KsB0fHcx6l&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #4573  +/-   ##
   =
   + Coverage71.2%   71.2%   +<.01% 
   =
 Files 187 187  
 Lines   14785   14786   +1 
 Branches 10831083  
   =
   + Hits10527   10528   +1 
 Misses   42554255  
 Partials3   3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4573/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.46% <100%> (+0.01%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=footer).
 Last update 
[9ad50c9...621db52](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services