codecov-io commented on issue #4607: [slice_json] pass slice id to get_form_data() URL: https://github.com/apache/incubator-superset/pull/4607#issuecomment-372784539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4607?src=pr&el=h1) Report > Merging [#4607](https://codecov.io/gh/apache/incubator-superset/pull/4607?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/de4409835ed6f8d625225591ac828973213550e1?src=pr&el=desc) will **increase** coverage by `0.9%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4607/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4607?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4607 +/- ## ========================================= + Coverage 71.18% 72.08% +0.9% ========================================= Files 189 189 Lines 14847 15512 +665 Branches 1086 1086 ========================================= + Hits 10569 11182 +613 - Misses 4275 4327 +52 Partials 3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4607?src=pr&el=tree) | Coverage ? | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4607/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.19% <0%> (+0.05%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4607/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `79.69% <0%> (+3.37%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4607/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.86% <0%> (+3.4%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4607?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4607?src=pr&el=footer). Last update [de44098...0210bf0](https://codecov.io/gh/apache/incubator-superset/pull/4607?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services