[GitHub] codecov-io commented on issue #4623: Use granularity for time step in play slider
codecov-io commented on issue #4623: Use granularity for time step in play slider URL: https://github.com/apache/incubator-superset/pull/4623#issuecomment-373574524 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=h1) Report > Merging [#4623](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/41c158edac43a8278d150f2e1add49dda2e338fa?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4623 +/- ## == + Coverage 72.63% 72.67% +0.03% == Files 205 206 +1 Lines 1540315424 +21 Branches 1183 1185 +2 == + Hits1118811209 +21 Misses 4212 4212 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <ø> (ø)` | :arrow_up: | | [superset/assets/javascripts/modules/time.js](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvdGltZS5qcw==) | `100% <100%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=footer). Last update [41c158e...a787c4a](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4623: Use granularity for time step in play slider
codecov-io commented on issue #4623: Use granularity for time step in play slider URL: https://github.com/apache/incubator-superset/pull/4623#issuecomment-373574524 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=h1) Report > Merging [#4623](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2bd40c89f98349ccf6a4c56609c13ec0c781f83?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4623 +/- ## == + Coverage 71.19% 71.27% +0.07% == Files 189 191 +2 Lines 1484414905 +61 Branches 1087 1101 +14 == + Hits1056810623 +55 - Misses 4273 4279 +6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <ø> (-0.58%)` | :arrow_down: | | [superset/assets/javascripts/modules/time.js](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvdGltZS5qcw==) | `100% <100%> (ø)` | | | [superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.95% <0%> (-0.56%)` | :arrow_down: | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `51.89% <0%> (-0.46%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.52% <0%> (-0.19%)` | :arrow_down: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <0%> (ø)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100% <0%> (ø)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <0%> (ø)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.46% <0%> (ø)` | :arrow_up: | | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=footer). Last update [e2bd40c...e9e30ef](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4623: Use granularity for time step in play slider
codecov-io commented on issue #4623: Use granularity for time step in play slider URL: https://github.com/apache/incubator-superset/pull/4623#issuecomment-373574524 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=h1) Report > Merging [#4623](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2bd40c89f98349ccf6a4c56609c13ec0c781f83?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4623 +/- ## == + Coverage 71.19% 71.23% +0.04% == Files 189 190 +1 Lines 1484414867 +23 Branches 1087 1089 +2 == + Hits1056810591 +23 Misses 4273 4273 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.16% <ø> (ø)` | :arrow_up: | | [superset/assets/javascripts/modules/time.js](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvdGltZS5qcw==) | `100% <100%> (ø)` | | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.24% <0%> (+0.06%)` | :arrow_up: | | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `71.96% <0%> (+0.26%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=footer). Last update [e2bd40c...1b78067](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4623: Use granularity for time step in play slider
codecov-io commented on issue #4623: Use granularity for time step in play slider URL: https://github.com/apache/incubator-superset/pull/4623#issuecomment-373574524 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=h1) Report > Merging [#4623](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2bd40c89f98349ccf6a4c56609c13ec0c781f83?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4623 +/- ## == + Coverage 71.19% 71.23% +0.04% == Files 189 190 +1 Lines 1484414867 +23 Branches 1087 1089 +2 == + Hits1056810591 +23 Misses 4273 4273 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.16% <ø> (ø)` | :arrow_up: | | [superset/assets/javascripts/modules/time.js](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvdGltZS5qcw==) | `100% <100%> (ø)` | | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.24% <0%> (+0.06%)` | :arrow_up: | | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4623/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `71.96% <0%> (+0.26%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=footer). Last update [e2bd40c...1b78067](https://codecov.io/gh/apache/incubator-superset/pull/4623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
