[GitHub] graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests
graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests URL: https://github.com/apache/incubator-superset/pull/3993#issuecomment-365463834 Merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests
graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests URL: https://github.com/apache/incubator-superset/pull/3993#issuecomment-360253864 confirmed. i manually tested top 20+ dashboard and more slices in dev box with production data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests
graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests URL: https://github.com/apache/incubator-superset/pull/3993#issuecomment-360253864 confirmed. i manually tested top 20+ dashboard and more slices in dev box. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests
graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests URL: https://github.com/apache/incubator-superset/pull/3993#issuecomment-348794425 @kkalyan this feature should be backward-compatible with previous work. Note we build post body for `explore_json` endpoint, but query parameters(GET) are given precedence than the POST body. Explore view should support: - accessed by slice id, - accessed with full form_data parameter - accessed by shared url id, like `/r/20` - parameterizable embedded iframes, see the iframe generator icon in the chart header - download data in .csv, .json format if you see any use cases are broken by this feature, please let me know. Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests
graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests URL: https://github.com/apache/incubator-superset/pull/3993#issuecomment-348794425 @kkalyan this feature should be backward-compatible with previous work. Note we build post body for `explore_json` endpoint, but query parameters(GET) are given precedence than the POST body. Explore view should support: - accessed by slice id, - accessed by slice id with additional form_data parameter - accessed by shared url id, like `/r/20` - parameterizable embedded iframes, see the iframe generator icon in the chart header - download data in .csv, .json format if you see any use cases are broken by this feature, please let me know. Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests
graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests URL: https://github.com/apache/incubator-superset/pull/3993#issuecomment-348794425 @kkalyan this feature should be backward-compatible with previous work. Note we build post body for `explore_json` endpoint, but query parameters(GET) are given precedence than the POST body. Explore view should support: - access by slice id, - access by slice id with additional form_data parameter - access by shared url id, like `/r/20` - parameterizable embedded iframes, see the iframe generator icon in the chart header - download .csv, json format data if you see any use cases are broken by this feature, please let me know. Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests
graceguo-supercat commented on issue #3993: [Explore view] Use POST method for charting requests URL: https://github.com/apache/incubator-superset/pull/3993#issuecomment-348794425 @kkalyan this feature should be backward-compatible with previous work. Note we build post body for `explore_json` endpoint, but query parameters(GET) are given precedence than the POST body. Explore view should support: - access by slice id, - access by slice id with additional form_data parameter - access by saved url id, like `/r/20` - parameterizable embedded iframes if you see any use cases are broken by this feature, please let me know. Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
