[GitHub] hughhhh closed pull request #4497: [Bugfix] On Vistype changes, set until to default (now)

2018-03-05 Thread GitBox 
hug closed pull request #4497: [Bugfix] On Vistype changes, set until to 
default (now)
URL: https://github.com/apache/incubator-superset/pull/4497
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/explore/stores/store.js 
b/superset/assets/javascripts/explore/stores/store.js
index 02bd121e65..90c5140a95 100644
--- a/superset/assets/javascripts/explore/stores/store.js
+++ b/superset/assets/javascripts/explore/stores/store.js
@@ -81,9 +81,15 @@ export function getControlsState(state, form_data) {
 control.value = formData[k] !== undefined ? formData[k] : control.default;
 controlsState[k] = control;
   });
+
+  // With VisType change alter until to always hit default
+  controlsState.until.value = controlsState.until.default;
+
+
   if (viz.onInit) {
 return viz.onInit(controlsState);
   }
+
   return controlsState;
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh closed pull request #4497: [Bugfix] On Vistype changes, set until to default (now)

2018-03-02 Thread GitBox 
hug closed pull request #4497: [Bugfix] On Vistype changes, set until to 
default (now)
URL: https://github.com/apache/incubator-superset/pull/4497
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/explore/stores/store.js 
b/superset/assets/javascripts/explore/stores/store.js
index af809ed2fa..8953eb4cda 100644
--- a/superset/assets/javascripts/explore/stores/store.js
+++ b/superset/assets/javascripts/explore/stores/store.js
@@ -81,6 +81,10 @@ export function getControlsState(state, form_data) {
 control.value = formData[k] !== undefined ? formData[k] : control.default;
 controlsState[k] = control;
   });
+
+  // With VisType change alter until to always hit default
+  controlsState.until.value = controlsState.until.default;
+
   return controlsState;
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services