john-bodley closed pull request #4579: Removing [dashboard] and [slice] titles
to show name
URL: https://github.com/apache/incubator-superset/pull/4579
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/views/core.py b/superset/views/core.py
index d5cd1689c5..0aa34de6a6 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1297,9 +1297,9 @@ def explore(self, datasource_type=None,
datasource_id=None):
if datasource_type == 'table' \
else datasource.datasource_name
if slc:
- title = '[slice] ' + slc.slice_name
+ title = slc.slice_name
else:
- title = '[explore] ' + table_name
+ title = 'Explore - ' + table_name
return self.render_template(
'superset/basic.html',
bootstrap_data=json.dumps(bootstrap_data),
@@ -2064,7 +2064,7 @@ def dashboard(**kwargs): # noqa
'superset/dashboard.html',
entry='dashboard',
standalone_mode=standalone_mode,
- title='[dashboard] ' + dash.dashboard_title,
+ title=dash.dashboard_title,
bootstrap_data=json.dumps(bootstrap_data),
)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
