[GitHub] john-bodley commented on issue #4804: [upload csv to hive] fix call to unicodereader.next()

2018-04-11 Thread GitBox 
john-bodley commented on issue #4804: [upload csv to hive] fix call to 
unicodereader.next()
URL: 
https://github.com/apache/incubator-superset/pull/4804#issuecomment-380565990
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4804: [upload csv to hive] fix call to unicodereader.next()

2018-04-11 Thread GitBox 
john-bodley commented on issue #4804: [upload csv to hive] fix call to 
unicodereader.next()
URL: 
https://github.com/apache/incubator-superset/pull/4804#issuecomment-380565990
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4804: [upload csv to hive] fix call to unicodereader.next()

2018-04-10 Thread GitBox 
john-bodley commented on issue #4804: [upload csv to hive] fix call to 
unicodereader.next()
URL: 
https://github.com/apache/incubator-superset/pull/4804#issuecomment-380304142
 
 
   @timifasubaa it seems in Python 2 uses 
[reader.next()](https://github.com/jdunck/python-unicodecsv/blob/master/unicodecsv/py2.py#L116)
 whereas Python 3 uses 
[next(reader)](https://github.com/jdunck/python-unicodecsv/blob/master/unicodecsv/py3.py#L54).
 Is this what you mean by being unreliable? 
   
   For Python 2 there is a 
[next(reader)](https://github.com/jdunck/python-unicodecsv/blob/master/unicodecsv/py2.py#L216)
 method however the logic differs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services